Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bridge zombienet test back to the CI #3264

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Add bridge zombienet test back to the CI #3264

merged 9 commits into from
Feb 12, 2024

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Feb 8, 2024 •
edited
Loading

Related to #3176

This PR only adds the first bridge zombienet test back to the CI after fixing it, reverting #3071

Credits to @svyatonik for building all the CI infrastructure around this.

@serban300 serban300 added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges. labels Feb 8, 2024
@serban300 serban300 self-assigned this Feb 8, 2024
@serban300 serban300 requested a review from a team as a code owner February 8, 2024 13:35
@serban300 serban300 marked this pull request as draft February 8, 2024 13:35
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 8, 2024 13:36
@serban300 serban300 force-pushed the bridge-zombienet-ci branch 12 times, most recently from d08d132 to c20c2e4 Compare February 9, 2024 14:07
@serban300 serban300 mentioned this pull request Feb 9, 2024
Merged
@serban300 serban300 changed the title [Debug][WIP] Run bridge zombienet test in CI Add bridge zombienet test back in the CI Feb 12, 2024
@serban300 serban300 changed the title Add bridge zombienet test back in the CI Add bridge zombienet test back to the CI Feb 12, 2024
@serban300 serban300 marked this pull request as ready for review February 12, 2024 11:22
@serban300
Copy link
Contributor Author

@paritytech/ci this PR only reintroduces #2439 which was already approved. On top of that there are no significant changes to the CI logic. Could you take a quick look please ?

svyatonik
svyatonik approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an issue with running it in a merge queue. Please check #2940 - maybe we can include it here too

@serban300
Copy link
Contributor Author

There's also an issue with running it in a merge queue. Please check #2940 - maybe we can include it here too

Thanks ! Didn't know about it. Will take a look.

@serban300 serban300 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into paritytech:master with commit e661dc0 Feb 12, 2024
127 of 128 checks passed
@serban300 serban300 deleted the bridge-zombienet-ci branch February 12, 2024 17:43
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svyatonik svyatonik svyatonik approved these changes

@bkontur bkontur bkontur approved these changes

@acatangiu acatangiu acatangiu approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees

@serban300 serban300

Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serban300 @svyatonik @bkontur @acatangiu @alvicsam