Add `claim_assets` extrinsic to `pallet-xcm` #3403

franciscoaguirre · 2024-02-20T11:25:51Z

If an XCM execution fails or ends with leftover assets, these will be trapped.
In order to claim them, a custom XCM has to be executed, with the ClaimAsset instruction.
However, arbitrary XCM execution is not allowed everywhere yet and XCM itself is still not easy enough to use for users out there with trapped assets.
This new extrinsic in pallet-xcm will allow these users to easily claim their assets, without concerning themselves with writing arbitrary XCMs.

Part of fixing #3495

franciscoaguirre · 2024-02-20T11:32:37Z

bot fmt

command-bot · 2024-02-20T11:32:42Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5274796 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-d84311d5-e612-4d99-923e-9b7c4383a0d1 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-02-20T11:35:31Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5274796 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5274796/artifacts/download.

…in every runtime

franciscoaguirre · 2024-02-20T15:29:02Z

bot fmt

command-bot · 2024-02-20T15:29:08Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5280685 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-553d1d91-4d1f-4e36-ba58-b5ba944ed967 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-02-20T15:31:50Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5280685 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5280685/artifacts/download.

franciscoaguirre · 2024-02-20T16:25:09Z

bot help

command-bot · 2024-02-20T16:25:12Z

Here's a link to docs

franciscoaguirre · 2024-02-20T16:28:54Z

bot bench cumulus-assets --runtime asset-hub-westend --pallet pallet_xcm

command-bot · 2024-02-20T16:29:00Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5282967 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-90d2532d-a4e0-4919-97d9-408dbde57b98 to cancel this command or bot cancel to cancel all commands in this pull request.

…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

command-bot · 2024-02-20T17:36:57Z

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5282967 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5282967/artifacts/download.

franciscoaguirre · 2024-02-20T17:46:33Z

bot bench cumulus-assets --runtime asset-hub-rococo --pallet pallet_xcm
bot bench cumulus-collectives --pallet pallet_xcm
bot bench cumulus-coretime --runtime coretime-rococo --pallet pallet_xcm
bot bench cumulus-coretime --runtime coretime-westend --pallet pallet_xcm
bot bench cumulus-bridge-hubs --runtime bridge-hub-rococo --pallet pallet_xcm
bot bench cumulus-bridge-hubs --runtime bridge-hub-westend --pallet pallet_xcm
bot bench cumulus-people --runtime people-rococo --pallet pallet_xcm
bot bench cumulus-people --runtime people-westend --pallet pallet_xcm
bot bench polkadot-pallet --runtime rococo --pallet pallet_xcm
bot bench polkadot-pallet --runtime westend --pallet pallet_xcm

command-bot · 2024-02-20T17:46:41Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5284753 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-559e95c8-48fc-4d09-bd92-67ea9ed0ec63 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-02-20T17:46:46Z

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5284754 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=collectives-westend --runtime_dir=collectives --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-9182b51d-8c18-40fd-884b-7269a464bc36 to cancel this command or bot cancel to cancel all commands in this pull request.

polkadot/runtime/rococo/src/lib.rs

polkadot/xcm/pallet-xcm/src/lib.rs

If an XCM execution fails or ends with leftover assets, these will be trapped. In order to claim them, a custom XCM has to be executed, with the `ClaimAsset` instruction. However, arbitrary XCM execution is not allowed everywhere yet and XCM itself is still not easy enough to use for users out there with trapped assets. This new extrinsic in `pallet-xcm` will allow these users to easily claim their assets, without concerning themselves with writing arbitrary XCMs. Part of fixing #3495 --------- Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Backport #3403 to polkadot-sdk 1.7.0 Co-authored-by: Adrian Catangiu <adrian@parity.io>

* master: Finish documenting `#[pallet::xxx]` macros (#2638) Remove `as frame_system::DefaultConfig` from the required syntax in `derive_impl` (#3505) provisioner: allow multiple cores assigned to the same para (#3233) subsystem-bench: add regression tests for availability read and write (#3311) make SelfParaId a metadata constant (#3517) Fix crash of synced parachain node run with `--sync=warp` (#3523) [Backport] Node version and spec_version bumps and ordering of the prdoc files from 1.8.0 (#3508) Add `claim_assets` extrinsic to `pallet-xcm` (#3403)

…data * ao-collator-parent-head-data: add a comment (review) Finish documenting `#[pallet::xxx]` macros (#2638) Remove `as frame_system::DefaultConfig` from the required syntax in `derive_impl` (#3505) provisioner: allow multiple cores assigned to the same para (#3233) subsystem-bench: add regression tests for availability read and write (#3311) make SelfParaId a metadata constant (#3517) Fix crash of synced parachain node run with `--sync=warp` (#3523) [Backport] Node version and spec_version bumps and ordering of the prdoc files from 1.8.0 (#3508) Add `claim_assets` extrinsic to `pallet-xcm` (#3403)

If an XCM execution fails or ends with leftover assets, these will be trapped. In order to claim them, a custom XCM has to be executed, with the `ClaimAsset` instruction. However, arbitrary XCM execution is not allowed everywhere yet and XCM itself is still not easy enough to use for users out there with trapped assets. This new extrinsic in `pallet-xcm` will allow these users to easily claim their assets, without concerning themselves with writing arbitrary XCMs. Part of fixing paritytech#3495 --------- Co-authored-by: command-bot <> Co-authored-by: Adrian Catangiu <adrian@parity.io>

failedpolkatransfer · 2024-03-11T14:22:28Z

is there a steps in claiming trapped assets?

Polkadot-Forum · 2024-04-04T08:02:53Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/parity-tech-update-for-march/7226/1

Polkadot-Forum · 2024-05-10T14:54:36Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/xcm-user-and-developer-experience-improvements/4511/21

feat(pallet-xcm): Add extrinsic

cce9e41

franciscoaguirre requested a review from a team as a code owner February 20, 2024 11:25

franciscoaguirre changed the title ~~Add claim_assets extrinsic to pallet-xcm~~ Add claim_assets extrinsic to pallet-xcm Feb 20, 2024

franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Feb 20, 2024

docs(prdoc): Add PRDoc

6b70fab

".git/.scripts/commands/fmt/fmt.sh"

83b98a7

franciscoaguirre marked this pull request as draft February 20, 2024 11:36

franciscoaguirre added 5 commits February 20, 2024 12:43

fix(pallet-xcm): Add placeholders for benchmark

26bb21a

fix(pallet-xcm): Fix claim_assets benchmark

dafc0f3

fix(pallet-xcm): Make get_valid_asset return the existential deposit …

ff4a49c

…in every runtime

fix(pallet-xcm): Add get_valid_asset to mock runtime

961da48

Merge branch 'master' into claim-assets-extrinsic

ff557cc

".git/.scripts/commands/fmt/fmt.sh"

9afa9c4

acatangiu requested review from bkontur and acatangiu February 20, 2024 16:39

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

4631b48

…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm

IkerAlus mentioned this pull request Feb 26, 2024

Add asset claim support paritytech/asset-transfer-api#373

Closed

acatangiu approved these changes Feb 27, 2024

View reviewed changes

acatangiu added 2 commits February 27, 2024 15:52

Apply suggestions from code review

d045fe9

Merge branch 'master' into claim-assets-extrinsic

448aad5

acatangiu enabled auto-merge February 27, 2024 13:53

acatangiu added this pull request to the merge queue Feb 27, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024

acatangiu mentioned this pull request Feb 27, 2024

Add claim_assets extrinsic to pallet-xcm and make it available in next runtime release #3495

Closed

4 tasks

acatangiu added this pull request to the merge queue Mar 1, 2024

acatangiu mentioned this pull request Mar 1, 2024

BUG: XCM transfer of all funds fails and traps assets polkadot-fellows/runtimes#210

Closed

Merged via the queue into master with commit 6508866 Mar 1, 2024
129 of 130 checks passed

acatangiu deleted the claim-assets-extrinsic branch March 1, 2024 08:02

franciscoaguirre mentioned this pull request Mar 1, 2024

Add claim_assets extrinsic to pallet-xcm (#3403) #3539

Merged

acatangiu added a commit that referenced this pull request Mar 1, 2024

Add claim_assets extrinsic to pallet-xcm (#3403) (#3539)

8fba849

Backport #3403 to polkadot-sdk 1.7.0 Co-authored-by: Adrian Catangiu <adrian@parity.io>

acatangiu mentioned this pull request Mar 23, 2024

XCM delivery fee breaks XCM compatibility #3070

Closed

ahmadkaouk mentioned this pull request Jun 20, 2024

Upgrade to polkadot-sdk v1.11.0 moonbeam-foundation/moonbeam#2838

Merged

Roznovjak mentioned this pull request Sep 2, 2024

chore: upgrade to polkadot v1.11.0 galacticcouncil/Basilisk-node#666

Merged

Roznovjak mentioned this pull request Sep 13, 2024

chore: upgrade to polkadot v1.11.0 galacticcouncil/hydration-node#889

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `claim_assets` extrinsic to `pallet-xcm` #3403

Add `claim_assets` extrinsic to `pallet-xcm` #3403

franciscoaguirre commented Feb 20, 2024 •

edited by acatangiu

Loading

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

failedpolkatransfer commented Mar 11, 2024

Polkadot-Forum commented Apr 4, 2024

Polkadot-Forum commented May 10, 2024

Add claim_assets extrinsic to pallet-xcm #3403

Add claim_assets extrinsic to pallet-xcm #3403

Conversation

franciscoaguirre commented Feb 20, 2024 • edited by acatangiu Loading

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 • edited Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 • edited Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 • edited Loading

command-bot bot commented Feb 20, 2024

franciscoaguirre commented Feb 20, 2024

command-bot bot commented Feb 20, 2024 • edited Loading

command-bot bot commented Feb 20, 2024 • edited Loading

failedpolkatransfer commented Mar 11, 2024

Polkadot-Forum commented Apr 4, 2024

Polkadot-Forum commented May 10, 2024

Add `claim_assets` extrinsic to `pallet-xcm` #3403

Add `claim_assets` extrinsic to `pallet-xcm` #3403

franciscoaguirre commented Feb 20, 2024 •

edited by acatangiu

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading