Contracts Add new version for marking new stable API #3415
Conversation
pgherveou
force-pushed
the
pg/add-version
branch
from
b8b4e60
to
231acca
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
pgherveou
added
the
T7-smart_contracts
| /// Defines the current version of the HostFn APIs. | ||
| /// This is used to communicate the available APIs in pallet-contracts. | ||
| /// | ||
| /// The version is bumped any time a new HostFn is added or stabilized. |
There was a problem hiding this comment.
I'm thinking about if we're better off using more general semantics here. Something like impl_version that we generally increment every time a host fn is added/stabilized, but also every time we want to communicate some other change, like an important bug fix.
There was a problem hiding this comment.
I think this will be difficult to do with a linear numbers. Bugfixes will get backported and then this system will fall apart.
| /// Defines the current version of the HostFn APIs. | ||
| /// This is used to communicate the available APIs in pallet-contracts. | ||
| /// | ||
| /// The version is bumped any time a new HostFn is added or stabilized. |
There was a problem hiding this comment.
I think this will be difficult to do with a linear numbers. Bugfixes will get backported and then this system will fall apart.
Add a `ApiVersion` constant to the pallet-contracts Config to communicate with developers the current state of the host functions exposed by the pallet
Add a `ApiVersion` constant to the pallet-contracts Config to communicate with developers the current state of the host functions exposed by the pallet
Add a
ApiVersionconstant to the pallet-contracts Config to communicate with developers the current state of the host functions exposed by the pallet