Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-consensus-beefy: pump gossip engine while waiting for initialization conditions #3435

Merged
merged 15 commits into from
Feb 22, 2024
Merged

sc-consensus-beefy: pump gossip engine while waiting for initialization conditions #3435

merged 15 commits into from
Feb 22, 2024

Commits on Feb 21, 2024

  1. sc-consensus-beefy: raise threshold of pending gossip messages to 100k 

    This new threshold is inline with the thresholds of the other gossip protocols.
On Kusama where there are 1000 validators, each gossiping at least
one message per round, the 10k threshold gets hit during node restarts when
there is an expected lag between gossip engine initialization and BEEFY
worker initialization. During this lag, more than 10k messages build up
and an error message is put up. With this commit, that annoying message goes
away.

Signed-off-by: Adrian Catangiu <adrian@parity.io>
    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f3e531c View commit details
    Browse the repository at this point in the history

  2. reduce debug log verbosity

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b427877 View commit details
    Browse the repository at this point in the history

  3. refactor code for better usability

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    549dd21 View commit details
    Browse the repository at this point in the history

  4. remove pumping gossip from specialized fn, will add it at a higher level

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7a77838 View commit details
    Browse the repository at this point in the history

  5. move to a cleaner builder design

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    adebff5 View commit details
    Browse the repository at this point in the history

  6. move builder to crate top-level

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dec07a5 View commit details
    Browse the repository at this point in the history

  7. move all initialization to builder object

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d24bf03 View commit details
    Browse the repository at this point in the history

  8. pump gossip engine while waiting for initialization conditions

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9262ff3 View commit details
    Browse the repository at this point in the history

  9. add prdoc

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9884d85 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:paritytech/polkadot-sdk into fix-… 

    …beefy-gossip-error-message
    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    740f9c5 View commit details
    Browse the repository at this point in the history

  11. also pump the peers report mpsc channel

    @acatangiu
    acatangiu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    97cfe00 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. refactor some names and add more comments for clarity

    @acatangiu
    acatangiu committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    17ef635 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:paritytech/polkadot-sdk into fix-… 

    …beefy-gossip-error-message
    @acatangiu
    acatangiu committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1343c97 View commit details
    Browse the repository at this point in the history

  3. fix prdoc

    @acatangiu
    acatangiu committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d0ca295 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-beefy-gossip-error-message

    @acatangiu
    acatangiu authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    fe05285 View commit details
    Browse the repository at this point in the history