rpc server: add prometheus label is_rate_limited
#3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
is_rate_limitedis_rate_limited
jsdw
reviewed
Feb 29, 2024
Comment on lines
+176
to
+188
| let middleware_layer = match (metrics, rate_limit) { | ||
| (None, None) => None, | ||
| (Some(metrics), None) => Some( | ||
| MiddlewareLayer::new().with_metrics(Metrics::new(metrics, transport_label)), | ||
| ), | ||
| (None, Some(rate_limit)) => | ||
| Some(MiddlewareLayer::new().with_rate_limit_per_minute(rate_limit)), | ||
| (Some(metrics), Some(rate_limit)) => Some( | ||
| MiddlewareLayer::new() | ||
| .with_metrics(Metrics::new(metrics, transport_label)) | ||
| .with_rate_limit_per_minute(rate_limit), | ||
| ), | ||
| }; |
There was a problem hiding this comment.
would it be possible to do something like this instead to simplify a bit?:
let mut middleware_layer = MiddlewareLayer::new();
if let Some(metrics) = metrics {
middleware_layer = middleware_layer.with_metrics(Metrics::new(metrics, transport_label));
}
if let Some(rate_limit) = rate_limit {
middleware_layer = middleware_layer.with_rate_limit_per_minute(rate_limit);
}There was a problem hiding this comment.
It's possible but it doesn't make sense to enable middleware if it's empty that's why I did it like that i.e, to box the future when it's a no-op middleware.
jsdw
reviewed
Feb 29, 2024
Co-authored-by: James Wilson <james@jsdw.me>
lexnv
approved these changes
Mar 4, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
After some discussion with @kogeler after the we added the rate-limit middleware it may slow down the rpc call timings metrics significantly because it works as follows: 1. The rate limit guard is checked when the call comes and if a slot is available -> process the call 2. If no free spot is available then the call will be sleeping `jitter_delay + min_time_rate_guard` then woken up and checked at most ten times 3. If no spot is available after 10 iterations -> the call is rejected (this may take tens of seconds) Thus, this PR adds a label "is_rate_limited" to filter those out on the metrics "substrate_rpc_calls_time" and "substrate_rpc_calls_finished". I had to merge two middleware layers Metrics and RateLimit to avoid shared state in a hacky way. --------- Co-authored-by: James Wilson <james@jsdw.me>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion with @kogeler after the we added the rate-limit middleware it may slow down
the rpc call timings metrics significantly because it works as follows:
jitter_delay + min_time_rate_guardthen woken up and checked at most ten timesThus, this PR adds a label "is_rate_limited" to filter those out on the metrics "substrate_rpc_calls_time" and "substrate_rpc_calls_finished".
I had to merge two middleware layers Metrics and RateLimit to avoid shared state in a hacky way.