Crowdload burn remaining funds #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
liamaharon
approved these changes
Mar 15, 2024
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
kianenigma
reviewed
Mar 15, 2024
| @@ -576,7 +577,10 @@ pub mod pallet { | |||
| // can take care of that. | |||
| debug_assert!(Self::contribution_iterator(fund.fund_index).count().is_zero()); | |||
|
|
|||
| frame_system::Pallet::<T>::dec_providers(&Self::fund_account_id(fund.fund_index))?; | |||
| // Crowdloan over, burn all funds. | |||
| let _imba = CurrencyOf::<T>::make_free_balance_be(&pot, Zero::zero()); | |||
There was a problem hiding this comment.
dq but I don't get why this is needed; a CL is dissolve-able only when all funds are already returned, no? if not, I think it should be like this.
seems to be checked as a part of let can_dissolve = permitted && fund.raised.is_zero();
So the invariant is fund.raised should always be equal to CurrencyOf::<T>::free_balance(&pot)?
There was a problem hiding this comment.
Ahh okay, reading the test I realize that this is catering for the cases where a manual transfer happens to the fund account.
kianenigma
approved these changes
Mar 15, 2024
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Mar 24, 2024
Crowdloan account should burn all funds after a crowd loan got dissolved to ensure that the account is reaped correctly. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crowdloan account should burn all funds after a crowd loan got dissolved to ensure that the account is reaped correctly.