Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCM remove extra QueryId types from traits #3763

Merged
merged 1 commit into from
Mar 22, 2024
Merged

XCM remove extra QueryId types from traits #3763

merged 1 commit into from
Mar 22, 2024

Conversation

pgherveou
Copy link
Contributor

We do not need to make these traits generic over QueryId type, we can
just use the QueryId alias everywhere

@pgherveou pgherveou requested a review from a team as a code owner March 20, 2024 12:01
@pgherveou pgherveou changed the base branch from pg/demo_fungible to master March 20, 2024 12:01
@pgherveou pgherveou requested a review from a team as a code owner March 20, 2024 12:01
@pgherveou
XCM remove extra QueryId types from traits
b771e07 
We do not need to make these traits generic over QueryId type, we can
just use the QueryId alias everywhere
@pgherveou pgherveou force-pushed the pg/xcm-remove-extra-queryid-types-from-traits branch from a1fac67 to b771e07 Compare March 20, 2024 12:03
@pgherveou pgherveou added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Mar 20, 2024
@pgherveou
Copy link
Contributor Author

pgherveou commented Mar 20, 2024 •
edited
Loading

@franciscoaguirre these extra type QueryId on these traits seem unnecessary, we should just use the QueryId type alias, can you take a quick look at this refactoring?

franciscoaguirre
franciscoaguirre approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@franciscoaguirre franciscoaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It made sense to have them be generic, but XCM already exposes the QueryId type and it's always assumed to be an integer. Probably not an issue to fix it as an integer 👍

@acatangiu acatangiu added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 2f59e9e Mar 22, 2024
138 of 141 checks passed
@acatangiu acatangiu deleted the pg/xcm-remove-extra-queryid-types-from-traits branch March 22, 2024 19:09
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@pgherveou @dharjeezy
XCM remove extra QueryId types from traits (paritytech#3763)
3c7d6b0 
We do not need to make these traits generic over QueryId type, we can
just use the QueryId alias everywhere
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @franciscoaguirre @acatangiu