elastic scaling: preserve candidate ordering in provisioner #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tering candidates with validation code updates
alindima
added
R0-silent
|
The CI pipeline was cancelled due to failure one of the required jobs. |
eskimor
approved these changes
Mar 23, 2024
sandreim
approved these changes
Mar 25, 2024
Comment on lines
839
to
855
| let mut stop_at_index = None; | ||
| for (index, candidate) in para_candidates.iter().enumerate() { | ||
| if candidate.candidate().commitments.new_validation_code.is_some() { | ||
| if with_validation_code { | ||
| stop_at_index = Some(index); | ||
| break | ||
| } else { | ||
| with_validation_code = true; | ||
| } | ||
| } | ||
|
|
||
| with_validation_code = true; | ||
| } | ||
|
|
||
| true | ||
| }); | ||
| if let Some(stop_at_index) = stop_at_index { | ||
| merged_candidates.extend(para_candidates.into_iter().take(stop_at_index)); | ||
| } else { | ||
| merged_candidates.extend(para_candidates.into_iter()); | ||
| } |
There was a problem hiding this comment.
We could get rid of the stop_index and do something like this:
for candidate in para_candidates.into_iter() {
merged_candidates.push(candidate);
// Stop accumulating at first candidate with code upgrade.
if candidate.candidate().commitments.new_validation_code.is_some() {
break
}
}
There was a problem hiding this comment.
we don't want to stop accumulating after the first code upgrade. we just want to not accumulate any more code upgrades after the first code upgrade.
I modified the code to not use a stop_at_index though. I figured it must be more performant to batch extend a vec than pushing one-by-one. However, it's likely negligible anyway and it's less readable
eskimor
approved these changes
Mar 25, 2024
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3742