Fix spelling mistakes across the whole repository

[dcompoze]

Update: Pushed additional changes based on the review comments.

This pull request fixes various spelling mistakes in this repository.

Most of the changes are contained in the first 3 commits:

• Fix spelling mistakes in comments and docs

• Fix spelling mistakes in test names

• Fix spelling mistakes in error messages, panic messages, logs and tracing

Other source code spelling mistakes are separated into individual commits for easier reviewing:

• Fix the spelling of 'authority'

• Fix the spelling of 'REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY'

• Fix the spelling of 'prev_enqueud_messages'

• Fix the spelling of 'endpoint'

• Fix the spelling of 'children'

• Fix the spelling of 'PenpalSiblingSovereignAccount'

• Fix the spelling of 'PenpalSudoAccount'

• Fix the spelling of 'insufficient'

• Fix the spelling of 'PalletXcmExtrinsicsBenchmark'

• Fix the spelling of 'subtracted'

• Fix the spelling of 'CandidatePendingAvailability'

• Fix the spelling of 'exclusive'

• Fix the spelling of 'until'

• Fix the spelling of 'discriminator'

• Fix the spelling of 'nonexistent'

• Fix the spelling of 'subsystem'

• Fix the spelling of 'indices'

• Fix the spelling of 'committed'

• Fix the spelling of 'topology'

• Fix the spelling of 'response'

• Fix the spelling of 'beneficiary'

• Fix the spelling of 'formatted'

• Fix the spelling of 'UNKNOWN_PROOF_REQUEST'

• Fix the spelling of 'succeeded'

• Fix the spelling of 'reopened'

• Fix the spelling of 'proposer'

• Fix the spelling of 'InstantiationNonce'

• Fix the spelling of 'depositor'

• Fix the spelling of 'expiration'

• Fix the spelling of 'phantom'

• Fix the spelling of 'AggregatedKeyValue'

• Fix the spelling of 'randomness'

• Fix the spelling of 'defendant'

• Fix the spelling of 'AquaticMammal'

• Fix the spelling of 'transactions'

• Fix the spelling of 'PassingTracingSubscriber'

• Fix the spelling of 'TxSignaturePayload'

• Fix the spelling of 'versioning'

• Fix the spelling of 'descendant'

• Fix the spelling of 'overridden'

• Fix the spelling of 'network'

Let me know if this structure is adequate.

Note: The usage of the words Merkle, Merkelize, Merklization, Merkelization, Merkleization, is somewhat inconsistent but I left it as it is.

Note: In some places the term Receival is used to refer to message reception, IMO Reception is the correct word here, but I left it as it is.

Note: In some places the term Overlayed is used instead of the more acceptable version Overlaid but I also left it as it is.

Note: In some places the term Applyable is used instead of the correct version Applicable but I also left it as it is.

Note: Some usage of British vs American english e.g. judgement vs judgment, initialise vs initialize, optimise vs optimize etc. are both present in different places, but I suppose that's understandable given the number of contributors.

Note: There is a spelling mistake in .github/CODEOWNERS but it triggers errors in CI when I make changes to it, so I left it as it is.

[cla-bot-2021]

User @dcompoze, please sign the CLA here.

[joepetrowski]

🙌

Note: In some places the term Receival is used to refer to message reception, IMO Reception is the correct word here, but I left it as it is.

I agree with Reception.

Note: In some places the term Overlayed is used instead of the more acceptable version Overlaid but I also left it as it is.

Agree with this change, laid is the correct past participle of lay.

Note: In some places the term Aplyable is used instead of the correct version Applicable but I also left it as it is.

Agree, would also change this.

Note: There is a spelling mistake in .github/CODEOWNERS but it triggers errors in CI when I make changes to it, so I left it as it is.

What error? I would fix it too.

[joepetrowski]

Note: Some usage of British vs American english e.g. judgement vs judgment, initialise vs initialize, optimise vs optimize etc. are both present in different places, but I suppose that's understandable given the number of contributors.

Our general approach is to use "most common", but yeah some of these slip in. Here is a nice old reference for you: paritytech/substrate#2138

I am a big fan of Ngram for these decisions, e.g. initialize vs. initialise. Just pick the most common.

[ggwpez]

This introduces breaking changes to lots of crates.
I am not sure if we are doing our downstream teams a favour with this.
It should at least mention all breaking changes in a prdoc.

[dcompoze]

I can document all the crate API-level changes in a PRDoc, unless you want to revert those types of changes.

[ggwpez]

I can document all the crate API-level changes in a PRDoc, unless you want to revert those types of changes.

Yes i veto this on account of being unreviewable. There is no way to ensure that no storage-alias or similar was changed without going over everything manually.
If it only updates doc comments then its okay IMHO.

[dcompoze]

So you want to revert all the code-level changes? @ggwpez

What about code changes such as:

• Test and benchmark code (e.g. test function names)

• Code not directly related to polkadot/substrate e.g. bridges, cli tools, scripts

• Changes to tracing messages, error messages, panic messages and log messages

I'm assuming the problematic changes are the ones that affect either the public API of crates or the blockchain runtime (i.e. different Wasm blob generated).

[ggwpez]

I'm assuming the problematic changes are the ones that affect either the public API of crates or the blockchain runtime (i.e. different Wasm blob generated).

Yea. Im my personal opinion, we should only break APIs that are in use by downstream teams for good reasons. Internal stuff is fine.

[bkchr]

Yea. Im my personal opinion, we should only break APIs that are in use by downstream teams for good reasons. Internal stuff is fine.

Maybe I have overseen it, but there wasn't that many breaking external changes? Mainly I remember the bridges stuff, which is probably only used by us and some of the metrics. What else?

[dcompoze]

I'm just going through the commits to check which changes affect the public API, so far found 1, will update in a sec.

[dcompoze]

OK, so I went through all the commits and found the changes that affect the public API in some way.

I documented them all in the PRDoc:

# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Fix spelling mistakes in source code

doc:
  - audience: Node Operator
    description: |
      Some spelling mistakes in log output, error messages and tracing (prometheus/grafana) have been fixed.
  - audience: Runtime Dev
    description: |
      Public crate changes:
      - The public trait `RuntimeParameterStore` in `substrate/frame/support` had the associated type renamed from `AggregratedKeyValue` to `AggregatedKeyValue`.
      - The public trait `AggregratedKeyValue` in `substrate/frame/support` was similarly renamed to `AggregatedKeyValue`.
      - The public methods `test_versioning` and `test_versioning_register_only` of the `TestApi` trait in `substrate/primitives/runtime-interface/test-wasm` had the spelling of `versionning` changed to `versioning`.
      - The public functions `read_trie_first_descendant_value` and `read_child_trie_first_descendant_value` in `substrate/primitives/trie` had the spelling of `descedant` changed to `descendant`.
crates:
  - name: frame-support
  - name: sp-runtime-interface-test-wasm
  - name: sp-trie

Alternatively, if there is consensus here to remove these changes, I can do that also.

[ggwpez]

The changes in frame-support are fine by me, since they are in experimental APIs.

The other stuff should probably be decided by @bkchr.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5645480

[dcompoze]

Thanks everyone!

[AndreiEres]

Unfortunately, this PR brought back recently deleted files

[ggwpez]

Looks like polkadot/node/subsystem-bench/src/lib/utils.rs is the only file that it added, or do you see more @AndreiEres?

[dcompoze]

My bad, must've been from the last rebase, I resolved the conflicts but didn't check the deleted files.

[AndreiEres]

Looks like polkadot/node/subsystem-bench/src/lib/utils.rs is the only file that it added

Great, then, I was afraid it could propagate to another ones. My file I already sorted out.