Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames frame crate to polkadot-sdk-frame #3813

Merged
merged 32 commits into from
Apr 4, 2024
Merged

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Mar 25, 2024

Step in #3155

Needed for paritytech/eng-automation#6

This PR renames frame crate to polkadot-sdk-frame as frame is not available on crates.io

@gupnik gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Mar 25, 2024
docs/sdk/Cargo.toml Outdated Show resolved Hide resolved
@xlc
Copy link
Contributor

xlc commented Mar 26, 2024

if we are going to do a rename, can we rename everything? e.g. all the staging- creates

@gupnik
Copy link
Contributor Author

gupnik commented Mar 26, 2024

if we are going to do a rename, can we rename everything? e.g. all the staging- creates

I will keep this one confined to the frame crate but please open an issue for the others that you would like to be renamed.

@gupnik gupnik marked this pull request as ready for review March 26, 2024 05:26
@gupnik gupnik requested a review from a team as a code owner March 26, 2024 05:26
@liamaharon
Copy link
Contributor

if we are going to do a rename, can we rename everything? e.g. all the staging- creates

I think for the ones with the staging- prefix we are actually in the process of recovering the rights to the original crate name. I don't think we should add to confusion by creating a new intermediate one.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say just import the crate with package = "poladkto-sdk-frame" and then the code more or less remain the same everywhere.

wdyt @ggwpez @liamaharon?

Similarly, in all template codes, we should still retain frame::prelude::* etc.

prdoc/pr_3813.prdoc Outdated Show resolved Hide resolved
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the direction of allowing polkadot-sdk-frame, and letting it be re-imported as frame. need better tests to ensure exactly these two scenarios are supported

codekitz and others added 5 commits April 1, 2024 13:48
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 3, 2024 05:44
@gupnik gupnik added this pull request to the merge queue Apr 4, 2024
Merged via the queue into master with commit 3836376 Apr 4, 2024
133 of 134 checks passed
@gupnik gupnik deleted the gupnik/frame-crate-rename branch April 4, 2024 02:51
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
Step in #3155

Needed for paritytech/eng-automation#6

This PR renames `frame` crate to `polkadot-sdk-frame` as `frame` is not
available on crates.io

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
Step in paritytech#3155

Needed for paritytech/eng-automation#6

This PR renames `frame` crate to `polkadot-sdk-frame` as `frame` is not
available on crates.io

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants