[DNM] Improvements on sponsored transaction fee through the new TransactionExtension interface
#3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: georgepisaltu <george.pisaltu@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #3712
Adapt the changes in fee sponsorship transaction extension to make everything compile and work (see previously introduced
free_transaction_extension_testwhich now passes).Also, the
free_transaction_extension_testtest case now tests a regular, non-sponsored transaction as well to make sure nothing is broken.Still a POC and not production ready.