Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derive syn parse 0.2.0 (+ docify) #3920

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Apr 1, 2024

derive-syn-parse v0.2.0 came out recently which (finally) adds support for syn 2x.

Upgrading to this will remove many of the places where syn 1x was still compiling alongside syn 2x in the polkadot-sdk workspace.

This also upgrades docify to 0.2.8 which is the version that upgrades derive-syn-pasre to 0.2.0.

Additionally, this consolidates the docify versions in the repo to all use the latest, and in one case upgrades to the 0.2x syntax where 0.1.x was still being used.

@sam0x17 sam0x17 requested a review from a team as a code owner April 1, 2024 06:47
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamaharon liamaharon added the R0-silent Changes should not be mentioned in any release notes label Apr 2, 2024
@liamaharon liamaharon added this pull request to the merge queue Apr 2, 2024
Merged via the queue into paritytech:master with commit 9a62de2 Apr 2, 2024
135 of 136 checks passed
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
derive-syn-parse v0.2.0 came out recently which (finally) adds support
for syn 2x.

Upgrading to this will remove many of the places where syn 1x was still
compiling alongside syn 2x in the polkadot-sdk workspace.

This also upgrades `docify` to 0.2.8 which is the version that upgrades
derive-syn-pasre to 0.2.0.

Additionally, this consolidates the `docify` versions in the repo to all
use the latest, and in one case upgrades to the 0.2x syntax where 0.1.x
was still being used.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
derive-syn-parse v0.2.0 came out recently which (finally) adds support
for syn 2x.

Upgrading to this will remove many of the places where syn 1x was still
compiling alongside syn 2x in the polkadot-sdk workspace.

This also upgrades `docify` to 0.2.8 which is the version that upgrades
derive-syn-pasre to 0.2.0.

Additionally, this consolidates the `docify` versions in the repo to all
use the latest, and in one case upgrades to the 0.2x syntax where 0.1.x
was still being used.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants