Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClaimQueue wrapper #3950

Merged
merged 28 commits into from
Apr 3, 2024
Merged

Add ClaimQueue wrapper #3950

merged 28 commits into from
Apr 3, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Apr 2, 2024

Remove fetch_next_scheduled_on_core in favor of new wrapper and methods for accessing it.

@sandreim
refactor: move claim queue fetch utils to utils crate
e3b5192 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
cache all groups per para and remove para:group 1:1 assumption
01ceb3b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
5ed7841 
…reim/elastic_statement_dist
@sandreim
typo
5f0872f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix test build
034b61a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
testing some local test run weirdness
9c91193 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix doctest
f87a624 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
remove panic
70213c5 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add new cluster test
4c66001 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add grid test
21ae63d 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
e923dac 
…reim/elastic_statement_dist

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt
27ee145 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
explicit max_candidate_depth
be1a2c7 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix test comment
b9f1afc 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
remove check for scheduled != occupied
17c4025 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
review feedback
a185390 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
39f480d 
…reim/elastic_statement_dist
@sandreim
review
d14384c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
review
9de1a04 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
ClaimQueueSnapshot wrapper
8c6b1ce 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim mentioned this pull request Apr 2, 2024
Merged
2 tasks
@sandreim
fix
fb8fb20 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim requested a review from tdimitrov April 3, 2024 08:18
@sandreim
fix 2
207e7ce 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
tdimitrov
tdimitrov reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@tdimitrov tdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. A few subsystem will work with the claim queue and will need similar boilerplate code to access it.

eskimor
eskimor reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

polkadot/node/subsystem-util/src/vstaging.rs Outdated Show resolved Hide resolved
@sandreim
add prdoc
fcfa2d4 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added the T0-node This PR/Issue is related to the topic “node”. label Apr 3, 2024
@sandreim
review
1740379 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim marked this pull request as ready for review April 3, 2024 08:46
@sandreim
update PRdoc
63c19cd 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Base automatically changed from sandreim/elastic_statement_dist to master April 3, 2024 08:57
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
5ac7d7e 
…reim/claim_queue_wrapper

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix build and fmt
dc15754 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim requested a review from tdimitrov April 3, 2024 10:57
@sandreim sandreim enabled auto-merge April 3, 2024 12:28
@sandreim
fix prdoc
933b927 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit 0f4e849 Apr 3, 2024
109 of 115 checks passed
@sandreim sandreim deleted the sandreim/claim_queue_wrapper branch April 3, 2024 15:24
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
@sandreim @Ank4n
Add ClaimQueue wrapper (#3950)
5a1b92d 
Remove `fetch_next_scheduled_on_core` in favor of new wrapper and
methods for accessing it.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@sandreim @dharjeezy
Add ClaimQueue wrapper (paritytech#3950)
f15110e 
Remove `fetch_next_scheduled_on_core` in favor of new wrapper and
methods for accessing it.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@TDemeco TDemeco mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@eskimor eskimor eskimor approved these changes

@alexggh alexggh alexggh approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandreim @tdimitrov @eskimor @alexggh