Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sp-wasm-interface: wasmtime should not be enabled by std #3954

Merged
merged 1 commit into from
Apr 3, 2024
Merged

sp-wasm-interface: wasmtime should not be enabled by std #3954

merged 1 commit into from
Apr 3, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 2, 2024

Closes: #3909

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Apr 2, 2024
@bkchr bkchr requested a review from a team April 2, 2024 20:14
@bkchr bkchr requested a review from koute as a code owner April 2, 2024 20:14
@bkchr bkchr mentioned this pull request Apr 2, 2024
Closed
2 tasks
ggwpez
ggwpez approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@michalkucharczyk michalkucharczyk requested a review from a team April 3, 2024 07:29
@bkchr bkchr added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit 9b378a2 Apr 3, 2024
140 of 142 checks passed
@bkchr bkchr deleted the bkchr-wasmtime-no-default branch April 3, 2024 09:07
Ank4n pushed a commit that referenced this pull request Apr 9, 2024
@bkchr @Ank4n
sp-wasm-interface: wasmtime should not be enabled by std (#3954)
5536d86 
Closes: #3909
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
@bkchr @dharjeezy
sp-wasm-interface: wasmtime should not be enabled by std (parityt…
d5d2408 
…ech#3954)

Closes: paritytech#3909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koute koute koute approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@ggwpez ggwpez ggwpez approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build for IOS if referencing sp-core/std many library std libraries that link to sp-core/std
5 participants
@bkchr @koute @michalkucharczyk @ggwpez @lexnv