Pvf refactor execute worker errors follow up #4071
Conversation
s0me0ne-unkn0wn
added
R0-silent
| @@ -136,6 +136,8 @@ pub enum InternalValidationError { | |||
| /// Could not find or open compiled artifact file. | |||
| #[error("validation: could not find or open compiled artifact file: {0}")] | |||
| CouldNotOpenFile(String), | |||
| #[error("validation: could not create pipe: {0}")] | |||
There was a problem hiding this comment.
Docstring is missing
There was a problem hiding this comment.
Thank you!) Fixed 5bdda49
|
/tip small |
|
@s0me0ne-unkn0wn You are not allowed to request a tip. Only members of paritytech/tip-bot-approvers are allowed. |
|
Oh you don't say |
| pin-project = "1.0.9" | ||
| rand = "0.8.5" | ||
| slotmap = "1.0" | ||
| tempfile = "3.3.0" | ||
| thiserror = { workspace = true } | ||
| tokio = { version = "1.24.2", features = ["fs", "process"] } | ||
|
|
||
| parity-scale-codec = { version = "3.6.1", default-features = false, features = ["derive"] } | ||
| parity-scale-codec = { version = "3.6.1", default-features = false, features = [ |
There was a problem hiding this comment.
nit, different formatter settings here and below
There was a problem hiding this comment.
Not sure if I've got it right, but it is the result of applying taplo fmt polkadot/node/core/pvf/Cargo.toml --config .config/taplo.toml as in the ci job
| @@ -127,13 +137,23 @@ pub fn worker_entrypoint( | |||
| |mut stream, worker_info, security_status| { | |||
| let artifact_path = worker_dir::execute_artifact(&worker_info.worker_dir_path); | |||
|
|
|||
| let Handshake { executor_params } = recv_execute_handshake(&mut stream)?; | |||
| let Handshake { executor_params } = map_err!( | |||
There was a problem hiding this comment.
nit: what do you think if we rewrite it something like that?
let Handshake { executor_params } = recv_execute_handshake(&mut stream)
.map_err(|e| map_and_send_err!(e, InternalValidationError::HostCommunication, &mut stream, worker_info))?;
More words, but easier to read imho
There was a problem hiding this comment.
Sure) thanks:) refactored at a05897f
|
/tip small |
|
@bkchr A referendum for a small (4 KSM) tip was successfully submitted for @maksimryndin (FZXVQLqLbFV2otNXs6BMnNch54CFJ1idpWwjMb3Z8fTLQC6 on kusama). Referendum number: 378. |
|
The referendum has appeared on Polkassembly. |
4eabe5e
follow up of #2604
closes #2604
Some unpassed ci problems are more general and should be fixed in master (see #4074)Proposed labels: T0-node, R0-silent, I4-refactor
kusama address: FZXVQLqLbFV2otNXs6BMnNch54CFJ1idpWwjMb3Z8fTLQC6