Bridge: added free headers submission support to the substrate-relay #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of_ex + check it from the transaction extension
… to RefundBridgedGrandpaMessages
… messages transactions
…ty (this is not used yet - see next commit)
…ge GRANDPA transactions are obsolete and, if not, it may apply priority boost to
…coming from CheckAndBoostBridgeGrandpaTransactions
…de of tx body, it is `None` and otherwise it is `Some`
…`improved_by` from extension code
…g in HeadersToRelay::Free mode
acatangiu
approved these changes
Apr 23, 2024
4 tasks
Base automatically changed from
sv-refund-non-mandatory-headers-fee-polkadot-sdk
to
master
April 25, 2024 05:54
@acatangiu I've added prdoc, but there's no "audience" that is suitable for us. Most suitable in this case is "Node Dev", but I guess everyone who's watching bridge can get all updates from |
serban300
approved these changes
Apr 25, 2024
bkontur
reviewed
Apr 25, 2024
| // if we see that the header schedules GRANDPA change, we need to submit it | ||
| if self.sync_params.only_mandatory_headers { | ||
| if self.sync_params.headers_to_relay == HeadersToRelay::Mandatory { |
There was a problem hiding this comment.
What about allowing here also HeadersToRelay::All?
There was a problem hiding this comment.
Sorry, I don't get what you mean. Can you, please, elaborate? All and Free are handled later, in the selector.select call.
There was a problem hiding this comment.
nvm, I need to walk through the entire PR first :)
svyatonik
added a commit
that referenced
this pull request
May 8, 2024
…4157) Original PR: paritytech/parity-bridges-common#2884. Since chain-specific code lives in the `parity-bridges-common` repo, some parts of original PR will require another PR --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…aritytech#4157) Original PR: paritytech/parity-bridges-common#2884. Since chain-specific code lives in the `parity-bridges-common` repo, some parts of original PR will require another PR --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: paritytech/parity-bridges-common#2884. Since chain-specific code lives in the
parity-bridges-commonrepo, some parts of original PR will require another PR