Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert execute_blob and send_blob (#4266) #4290

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Revert execute_blob and send_blob (#4266) #4290

merged 4 commits into from
Apr 29, 2024

Conversation

franciscoaguirre
Copy link
Contributor

Revert "pallet-xcm: Deprecate execute and send in favor of execute_blob and send_blob (#3749)"

This reverts commit feee773.

@franciscoaguirre @acatangiu @Bullrich
Revert execute_blob and send_blob (#4266)
c9633fe 
Revert "pallet-xcm: Deprecate `execute` and `send` in favor of
`execute_blob` and `send_blob` (#3749)"

This reverts commit feee773.

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Javier Bullrich <javier@bullrich.dev>
@franciscoaguirre franciscoaguirre requested review from athei and a team as code owners April 25, 2024 11:13
@franciscoaguirre franciscoaguirre added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Apr 25, 2024
acatangiu
acatangiu approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also change or remove the original prdoc.

Please also locally run:
cargo test -p pallet-xcm
and
cargo test -r -p asset-hub-westend-integration-tests -p bridge-hub-westend-integration-tests -p asset-hub-rococo-integration-tests -p bridge-hub-rococo-integration-tests -p <all-other-chains>

as the CI is not doing it for this branch..

@franciscoaguirre
Copy link
Contributor Author

@acatangiu

Removed the prdoc.
All tests are passing locally. The errors in CI seem unrelated.

@Morganamilo
Copy link
Contributor

You still need a PRDoc for this PR

@franciscoaguirre
Copy link
Contributor Author

You still need a PRDoc for this PR

Put the R0-silent label, since this is just reverting a previous change

@Morganamilo
Copy link
Contributor

A prdoc is still needed to tell the release tooling what crate to release once merged.

@franciscoaguirre
Copy link
Contributor Author

A prdoc is still needed to tell the release tooling what crate to release once merged.

Didn't know our release tooling used prdocs. I added one, please let me know if it's okay

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6060715

@acatangiu acatangiu merged commit 8568329 into release-crates-io-v1.10.0 Apr 29, 2024
23 of 126 checks passed
@acatangiu acatangiu deleted the patch-revert-execute-blob branch April 29, 2024 15:17
@acatangiu
Copy link
Contributor

acatangiu commented Apr 29, 2024 •
edited
Loading

@Morganamilo can we get a new release on crates.io for pallet-xcm -> 11.1.0, then yank the existing 11.0.0 version?

@RomarQ RomarQ mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@Morganamilo Morganamilo Morganamilo approved these changes

@bkontur bkontur bkontur approved these changes

@athei athei Awaiting requested review from athei athei is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franciscoaguirre @Morganamilo @paritytech-cicd-pr @acatangiu @bkontur