Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcm-emlator: Use BlockNumberFor instead of parachains_common::BlockNumber=u32 #4434

Merged
merged 1 commit into from
May 12, 2024
Merged

xcm-emlator: Use BlockNumberFor instead of parachains_common::BlockNumber=u32 #4434

merged 1 commit into from
May 12, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented May 10, 2024 •
edited
Loading

Closes: #4428

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. labels May 10, 2024
@bkontur bkontur mentioned this pull request May 10, 2024
Closed
@acatangiu acatangiu added this pull request to the merge queue May 12, 2024
Merged via the queue into master with commit 9e0e5fc May 12, 2024
156 of 157 checks passed
@acatangiu acatangiu deleted the bko-xcm-emulator-4428 branch May 12, 2024 16:17
ordian added a commit that referenced this pull request May 14, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
fe4ea5f 
* master:
  improve MockValidationDataInherentDataProvider to support async backing (#4442)
  Bump `proc-macro-crate` to the latest version (#4409)
  [ci] Run check-runtime-migration in GHA (#4441)
  prospective-parachains rework (#4035)
  [ci] Add forklift to GHA ARC (#4372)
  `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326)
  Add generate and verify logic for `AncestryProof` (#4430)
  Rococo AH: undeploy trie migration (#4414)
  Remove `substrate-frame-cli` (#4403)
  migrations: `take()`should consume read and write operation weight (#4302)
  `remote-externalities`: store block header in snapshot (#4349)
  xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434)
  Remove `pallet::getter` usage from authority-discovery pallet (#4091)
  Remove pallet::getter usage from pallet-contracts-mock-network (#4417)
  Add docs to request_core_count (#4423)
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
723008f 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
(cherry picked from commit 9e0e5fc)
@ntn-x2 ntn-x2 mentioned this pull request May 17, 2024
Merged
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
72dd732 
…kNumber=u32` (#4434) (#4493)

Cherry-picked from `master` (#4434). Context:
#4428.

I don't see any other way than opening other PRs for each of the
released branches with this fix. If you guys have an alternative
proposal, I am all ears. Otherwise, I'll go ahead and open the other
ones once this gets merged.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
d2543dd 
…kNumber=u32` (paritytech#4434)

(cherry picked from commit 9e0e5fc)
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
e954767 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
f259795 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
42d04ee 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
ntn-x2 pushed a commit to KILTprotocol/polkadot-sdk that referenced this pull request May 17, 2024
@bkontur @ntn-x2
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
7c30c0c 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
c5e4466 
…kNumber=u32` (#4434) (#4496)

Context: #4428 and
#4493.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
6af5b98 
…kNumber=u32` (#4434) (#4497)

Context: #4428 and
#4493.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
6f36186 
…kNumber=u32` (#4434) (#4498)

Context: #4428 and
#4493.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
f41976a 
…kNumber=u32` (#4434) (#4499)

Context: #4428 and
#4493.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
acatangiu pushed a commit that referenced this pull request May 17, 2024
@ntn-x2 @bkontur
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
dd45882 
…kNumber=u32` (#4434) (#4500)

Context: #4428 and
#4493.

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@bkontur @hitchhooker
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
b913588 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
@bkontur @liuchengxu
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
8e09339 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@bkontur @TarekkMA
xcm-emlator: Use BlockNumberFor instead of `parachains_common::Bloc…
3c5ee59 
…kNumber=u32` (paritytech#4434)

Closes: paritytech#4428
@github-actions github-actions bot mentioned this pull request Aug 21, 2024
Open
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@acatangiu acatangiu acatangiu approved these changes

@liamaharon liamaharon liamaharon approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More flexible decl_test_parachains macro in XCM emulator for BlockNumber type
5 participants
@bkontur @bkchr @liamaharon @acatangiu @sandreim