Backport claim assets tests from polkadot-fellows repo

[programskillforverification]

Issue

Backport integration tests for claim assets to the polkadot-sdk from polkadot-fellows repo #4892

Description

For the first time to contribute this project, I just finished part and make sure everything is ok.

• backport claim_assets test case to the polkadot-sdk testnet integration tests
• backport macro test_chain_can_claim_assets from fellows repo
• when merged to polkadot-sdk and released, make sure that it is propagated to the fellows repo: Remove emulated test macros polkadot-fellows/runtimes#363
• backport and align other macros/test-cases from https://github.com/polkadot-fellows/runtimes/blob/8ec28f96eeb30fbba30d29006d75e1a3fa1cea1c/integration-tests/emulated/helpers/src/lib.rs#L31-L33

[cla-bot-2021]

User @programskillforverification, please sign the CLA here.

[bkontur]

bot fmt

[franciscoaguirre]

We probably want the test for claiming assets on all runtimes, thinking people chain and coretime chain for sure

[programskillforverification]

We probably want the test for claiming assets on all runtimes, thinking people chain and coretime chain for sure

@franciscoaguirre Okay, claiming assets will be added to people chain. But there is no any tests about coretime chain in whole integration tests directory. Are you sure to import it?

[acatangiu]

But there is no any tests about coretime chain in whole integration tests directory. Are you sure to import it?

Yes. We should add emulated tests for coretime chain as well.

[programskillforverification]

I just add tests in rococo. If everything is ok, especially config, I will add them in westend.

[acatangiu]

very nice, thanks @programskillforverification !

everything looks good, feel free to do the same for Westend.

Could you please also include the teleport tests for all chains that don't have it? (e.g. coretime emulated chains you just added)

[programskillforverification]

very nice, thanks @programskillforverification !

everything looks good, feel free to do the same for Westend.

Could you please also include the teleport tests for all chains that don't have it? (e.g. coretime emulated chains you just added)

What should the teleport tests include in coretime? Teleport tests looks different for different chains.

[acatangiu]

What should the teleport tests include in coretime? Teleport tests looks different for different chains.

Basic ROC (on Rococo) and WND (on Westend) teleport tests: between Coretime and Relay and between coretime and other system chains.

(this ^ should be minimum for all system chains)

[programskillforverification]

What should the teleport tests include in coretime? Teleport tests looks different for different chains.

Basic ROC (on Rococo) and WND (on Westend) teleport tests: between Coretime and Relay and between coretime and other system chains.

(this ^ should be minimum for all system chains)

Now, macro test_relay_is_trusted_teleporter! is already added.

/// Limited Teleport of native asset from Relay Chain to the System Parachain should work
#[test]
fn limited_teleport_native_assets_from_relay_to_system_para_works() {
	// Init values for Relay Chain
	let amount_to_send: Balance = WESTEND_ED * 1000;
	let dest = Westend::child_location_of(AssetHubWestend::para_id());
	let beneficiary_id = AssetHubWestendReceiver::get();
	let test_args = TestContext {
		sender: WestendSender::get(),
		receiver: AssetHubWestendReceiver::get(),
		args: TestArgs::new_relay(dest, beneficiary_id, amount_to_send),
	};

	let mut test = RelayToSystemParaTest::new(test_args);
...

Is this test function outdated? If so, I want to rewrite all teleport tests using macro.

[acatangiu]

Yes, limited_teleport_native_assets_from_relay_to_system_para_works can be replaced by macro version - it does the same thing.

[programskillforverification]

@franciscoaguirre PTAL

@programskillforverification are you part of Polkadot Fellowship? If not, please add a Polkadot address so we can provide a tip for this useful work 👍

Thanks a lot. I already add my address in my bio and submit a fellowship application.

[bkontur]

I think we should also reflect here upcoming changes for dry-run api from this PR: https://github.com/polkadot-fellows/runtimes/pull/380/files#diff-7346706278168c97dfec9e73bec1a115274a2be89a3147b914dd2eedec9f6269R57

[programskillforverification]

I think we should also reflect here upcoming changes for dry-run api from this PR: https://github.com/polkadot-fellows/runtimes/pull/380/files#diff-7346706278168c97dfec9e73bec1a115274a2be89a3147b914dd2eedec9f6269R57

I am refactoring teleport in a new PR, which covers some part of this PR. For XcmPaymentApi and DryRunApi, maybe are in separate PR.

[acatangiu]

Changes are good, you just have to make the CI happy - you can check the failed checks on their details button to find out what/why's failing

[programskillforverification]

Changes are good, you just have to make the CI happy - you can check the failed checks on their details button to find out what/why's failing

I fixed most except check-semver. The rust version need to be upgraded in check-semver to run it.

[acatangiu]

@bkontur @franciscoaguirre please review

[franciscoaguirre]

Thank you for this effort!