Explain usage of <T: Config> in FRAME storage + Update parachain pallet template
#4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also we can't have the banner printed all the time, because it leads to printing malformed chain specs.
+ small fixes
+ addressing some nits
kianenigma
added
R0-silent
kianenigma
changed the title
<T: Config> in FRAME storage + Update parachain pallet template
|
@kianenigma Command |
ggwpez
reviewed
Jul 5, 2024
ggwpez
reviewed
Jul 5, 2024
ggwpez
reviewed
Jul 5, 2024
ggwpez
reviewed
Jul 5, 2024
| @@ -755,7 +755,13 @@ pub mod pallet { | |||
| // We ignore this error as it just means the amount we're trying to deposit is | |||
| // dust and the beneficiary account doesn't exist. | |||
| .or_else( | |||
| |e| if e == TokenError::CannotCreate.into() { Ok(()) } else { Err(e) }, | |||
| |e| { | |||
| if e == TokenError::CannotCreate.into() { | |||
ggwpez
reviewed
Jul 5, 2024
ggwpez
reviewed
Jul 5, 2024
ggwpez
approved these changes
Jul 5, 2024
…aritytech/polkadot-sdk into kiz-update-tempalates-and-t-in-storage
|
bot fmt |
|
"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued. Comment |
|
@kianenigma Command |
gpestana
approved these changes
Jul 10, 2024
| @@ -1,4 +1,7 @@ | |||
| //! A shell pallet built with [`frame`]. | |||
| //! | |||
| //! To get started with this pallet, try implementing the guide in | |||
| //! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html> | |||
There was a problem hiding this comment.
Suggested change
| //! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html> | |
| //! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html>. |
jasl
reviewed
Jul 10, 2024
| @@ -25,10 +25,13 @@ frame-benchmarking = { optional = true, workspace = true } | |||
| frame-support = { workspace = true } | |||
| frame-system = { workspace = true } | |||
|
|
|||
| # primitive deps | |||
| sp-runtime = { workspace = true } | |||
| sp-std = { workspace = true } | |||
There was a problem hiding this comment.
Was sp-std be proposed to soft deprecate?
#2101
There was a problem hiding this comment.
hmm I see, a mistake indeed. Would you like to open a PR that reverts this + added a deprecation warning to sp-std, preventing this from happening?
There was a problem hiding this comment.
I think I can make a following PR to remove the usage of sp-std here.
I don't know how to warn deprecation for a crate...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Following PR for #4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on #2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
TomaszWaszczyk
pushed a commit
to TomaszWaszczyk/polkadot-sdk
that referenced
this pull request
Jul 13, 2024
…llet template (paritytech#4941) Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on. I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up. - [x] Update possible answers in SE about the same topic. --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <>
TomaszWaszczyk
pushed a commit
to TomaszWaszczyk/polkadot-sdk
that referenced
this pull request
Jul 13, 2024
Following PR for paritytech#4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on paritytech#2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ordian
added a commit
that referenced
this pull request
Jul 15, 2024
* master: (120 commits) network/tx: Ban peers with tx that fail to decode (#5002) Try State Hook for Bounties (#4563) [statement-distribution] Add metrics for distributed statements in V2 (#4554) added sync command (#4818) Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935) xcm-executor: Improve logging (#4996) Remove usage of `sp-std` on templates (#5001) fixed cmd bot commenting not working (#5000) Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template (#4941) Expose metadata-hash feature from polkadot crate (#4886) Add `MAX_INSTRUCTIONS_TO_DECODE` to XCMv2 (#4978) add notices to the implementer's guide docs that changed for elastic scaling (#4983) `polkadot-parachain` simplifications and deduplications (#4916) Update Templates README docs (#4980) allow clear_origin in safe xcm builder (#4777) litep2p/peerstore: Fix bump last updated time (#4971) Make `tracing::log` work in the runtime (#4863) sp-core: Improve docs generated by `generate_feature_enabled_macro` (#4968) [Backport] Version bumps and prdocs reordering from 1.14.0 (#4955) Assets: can_decrease/increase for destroying asset is not successful (#3286) ...
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…llet template (paritytech#4941) Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on. I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up. - [x] Update possible answers in SE about the same topic. --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Following PR for paritytech#4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on paritytech#2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on.
I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up.