Beefy equivocation: add runtime API methods #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
acatangiu
approved these changes
Jul 11, 2024
bkontur
approved these changes
Jul 23, 2024
| @@ -349,6 +349,19 @@ pub struct ForkVotingProof<Header: HeaderT, Id: RuntimeAppPublic, AncestryProof> | |||
| pub header: Header, | |||
| } | |||
|
|
|||
| impl<Header: HeaderT, Id: RuntimeAppPublic> ForkVotingProof<Header, Id, OpaqueValue> { | |||
| /// Try to decode the `AncestryProof`. | |||
| pub fn try_into<AncestryProof: Decode>( | |||
There was a problem hiding this comment.
@serban300 impl TryInto or TryFrom does not work here?
There was a problem hiding this comment.
I tried, but TryInto must return an Error and here it was better to return an Option.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
paritytech:master
with commit Jul 23, 2024
216e8fa
158 of 161 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Related to paritytech#4523 Add runtime API methods for: - generating the ancestry proof - submiting a fork voting report - submitting a future voting report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4523
Add runtime API methods for: