Use Mutex in HeaderMetadataCache
#5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it really faster? :P We can merge this, but not sure. |
bkchr
approved these changes
Jul 18, 2024
Merged
via the queue into
paritytech:master
with commit Jul 18, 2024
d97fbb1
161 of 164 checks passed
|
A little bit, but yes, Mutex is always strictly faster than RwLock, any implementation |
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Due to `LruMap` usage it is not actually possible to leverage read feature of `RwLock`, hence change to `Mutex` that is faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
LruMapusage it is not actually possible to leverage read feature ofRwLock, hence change toMutexthat is faster