Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run UI tests in CI for some other crates #5167

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Run UI tests in CI for some other crates #5167

merged 11 commits into from
Jul 31, 2024

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jul 28, 2024

The test name is test-frame-ui I don't know if I can also change it to test-ui without breaking other stuff. So I kept the name unchanged.

@gui1117 gui1117 requested a review from a team as a code owner July 28, 2024 12:56
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jul 28, 2024
@bkchr bkchr requested a review from ggwpez July 28, 2024 18:53
@gui1117
Copy link
Contributor Author

gui1117 commented Jul 29, 2024 •
edited
Loading

xcm-procedural ui test are failing to compile because of this: dtolnay/trybuild#282

Fixed

@bkchr
Copy link
Member

bkchr commented Jul 29, 2024

@gui1117 can you please change version of trybuild in the workspace Cargo.toml as well?

@gui1117
Copy link
Contributor Author

gui1117 commented Jul 29, 2024

@gui1117 can you please change version of trybuild in the workspace Cargo.toml as well?

yes done in 47d75df

ggwpez
ggwpez reviewed Jul 29, 2024
View reviewed changes
.gitlab/pipeline/test.yml Outdated Show resolved Hide resolved
@ggwpez ggwpez enabled auto-merge July 29, 2024 10:47
@bkchr
Copy link
Member

bkchr commented Jul 29, 2024

@gui1117 could you update the UI tests? :D

@ggwpez
Copy link
Member

ggwpez commented Jul 29, 2024 •
edited
Loading

bot update-ui

(Lets try, if it does not work, then we have to fix the bot)

@command-bot
Copy link

command-bot bot commented Jul 29, 2024 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6847716 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-489bf9d0-4ad8-4595-8a06-3d9447fbd6e7 to cancel this command or bot cancel to cancel all commands in this pull request.

@github-actions GitHub Actions
Copy link

We are migrating the command bot to be a GitHub Action

Please, see the documentation on how to use it

@github-actions GitHub Actions
Copy link

Command failed ❌

Run by @ggwpez for Command Update UI failed. See logs here.

@mordamax
Copy link
Contributor

bot update-ui

(Lets try, if it does not work, then we have to fix the bot)

it did start ok, https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6847716

@command-bot
Copy link

command-bot bot commented Jul 29, 2024

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6847716 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6847716/artifacts/download.

@gui1117
Copy link
Contributor Author

gui1117 commented Jul 30, 2024 •
edited
Loading

new version of trybuild seems to break the CI.

It seems that "--deny warnings" is not propagated anymore.

I guess because of this: dtolnay/trybuild#283

I will try to fix trybuild, but we can also modify all pass test and the relevant fail tests to have #[deny(warnings)]

@ggwpez
Copy link
Member

ggwpez commented Jul 30, 2024

I will try to fix trybuild, but we can also modify all pass test and the relevant fail tests to have #[deny(warnings)]

Hm, so the SKIP_WASM_BUILD will also not be supported? Then maybe roll back the update of trybuild until it is fixed upstream.

auto-merge was automatically disabled July 30, 2024 13:25

Head branch was pushed to by a user without write access

@gui1117 gui1117 requested a review from a team as a code owner July 30, 2024 13:25
@gui1117
Copy link
Contributor Author

gui1117 commented Jul 30, 2024

I reverted to old trybuild version and explicity set std as a feature so we don't need to rely on the fix: 092ffbc

@gui1117
Copy link
Contributor Author

gui1117 commented Jul 30, 2024

Hm, so the SKIP_WASM_BUILD will also not be supported? Then maybe roll back the update of trybuild until it is fixed upstream.

SKIP_WASM_BUILD should work, only RUSTFLAGS are removed from the environment.

@ggwpez ggwpez enabled auto-merge July 30, 2024 21:23
@ggwpez ggwpez added this pull request to the merge queue Jul 31, 2024
Merged via the queue into paritytech:master with commit 39daa61 Jul 31, 2024
157 of 159 checks passed
@gui1117 gui1117 deleted the gui-fix-CI branch July 31, 2024 09:58
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@gui1117 @bkchr @TarekkMA
Run UI tests in CI for some other crates (paritytech#5167)
2bc0da4 
The test name is `test-frame-ui` I don't know if I can also change it to
`test-ui` without breaking other stuff. So I kept the name unchanged.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
ordian added a commit that referenced this pull request Aug 6, 2024
@ordian
Merge branch 'master' into ao-fix-parainclusion-weight-overestimation
d305a1a 
* master: (51 commits)
  Remove unused feature gated code from the minimal template (#5237)
  make polkadot-parachain startup errors pretty (#5214)
  Coretime auto-renew (#4424)
  network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029)
  Fix frame crate usage doc (#5222)
  beefy: Tolerate pruned state on runtime API call (#5197)
  rpc: Enable ChainSpec for polkadot-parachain (#5205)
  Add an adapter for configuring AssetExchanger (#5130)
  Replace env_logger with sp_tracing (#5065)
  Adjust sync templates flow to use new release branch (#5182)
  litep2p/discovery: Publish authority records with external addresses only (#5176)
  Run UI tests in CI for some other crates (#5167)
  Remove `pallet::getter` usage from the pallet-balances (#4967)
  pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055)
  [CI] Cache try-runtime check (#5179)
  [Backport] version bumps and the prdocs reordering from stable2407 (#5178)
  [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180)
  Remove pallet::getter usage from proxy (#4963)
  Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487)
  Review-bot@2.6.0 (#5177)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gui1117 @bkchr @ggwpez @mordamax