polkadot-parachain: compile separate lib and bin #5288

serban300 · 2024-08-08T14:51:13Z

Related to #5210

kianenigma · 2024-08-09T09:42:56Z

cumulus/polkadot-parachain/src/chain_spec/contracts.rs

@@ -14,13 +14,11 @@
 // You should have received a copy of the GNU General Public License
 // along with Cumulus.  If not, see <http://www.gnu.org/licenses/>.

-use crate::chain_spec::{


@athei is this parachain even needed anymore? perhaps we should remove it.

We are working on a new testnet for for pallet_revive, I think it's safe to get rid of this one now

Okay, something to do in a follow-up then @serban300 :)

Opened PR #5471 for this

cumulus/polkadot-parachain/src/lib.rs

umbrella/src/lib.rs

kianenigma

lgtm module some kind of usage doc. What can I do with this lib now? what benefit it has to a parachain team? (except if you are @xlc and you know because you requested this 😉)

You can put it in the main lib.rs, and in the PR description.

@PierreBesson from what I can see, you should brace for either:

Parity needs to generate its own omni-node in order to keep things like --chain asset-hub backwards compatible.
Parity should prepare to replace all --chain <fixed-string> to --chain <json-file>.

In all honesty, I regret not pushing harder for separating polkadot-parachain and omni-node. We could have left polkadot-parachain as is for eternity, and started working on a fresh fork of it, giving us all the flexibility in the world. The fact that the omni-node is called polkadot-parachain (we agreed to not rename it in a separate PR) also still sounds counterproductive to me. It is buzz-killer. I do hope we rename it someday once the dust has settled :)

The benefit of what we do now is it that we are forced to dogfood the process of going from --chain name to --chain spec.json.

cumulus/polkadot-parachain/Cargo.toml

paritytech-cicd-pr · 2024-08-12T11:14:02Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: check-tracing
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6968216

cumulus/polkadot-parachain/Cargo.toml

xlc · 2024-08-13T22:32:10Z

cumulus/polkadot-parachain/Cargo.toml

 [features]
 default = []
 runtime-benchmarks = [
+	"cumulus-primitives-core/runtime-benchmarks",


we probably can remove all those features. I don't really know why they exists at the first place

If it's related to runtime-benchmarks I answered on a different comment below

xlc · 2024-08-13T22:32:51Z

cumulus/polkadot-parachain/polkadot-parachain-lib/Cargo.toml

+
+[features]
+default = []
+runtime-benchmarks = [


what are those for? we should use the standalone bencher and try-runtime-cli

We still need them in the CI for the bot ... commands. There is an item for removing them after we migrate the CI commands to the omni-bencher: #4966

cumulus/polkadot-parachain/polkadot-parachain-lib/Cargo.toml

cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/chain_spec.rs

xlc · 2024-08-13T23:23:36Z

I am trying this at https://github.com/AcalaNetwork/acala-node
The exposed API is easy enough.
The main issue I have is about deps. I shouldn't fine any runtime in Cargo.lock file. Ideally, it shouldn't contain any pallets and frame crates.
And maybe related to I am using a fork, many polkadot-sdk creates are pulled twice such as sp-std due to deps to creates at paritytech/arkworks-substrate

xlc

you will need the build.rs file in the bin, not in the lib

cumulus/polkadot-parachain/polkadot-parachain-lib/src/cli.rs

CommandConfig -> RunConfig copyright start year -> u16

serban300 · 2024-08-14T11:08:18Z

you will need the build.rs file in the bin, not in the lib

Done

serban300 · 2024-08-14T11:24:01Z

The main issue I have is about deps. I shouldn't fine any runtime in Cargo.lock file. Ideally, it shouldn't contain any pallets and frame crates.

Removed the rococo-native and westend-native. From what I see the pallets and frame crates are needed just for accessing some runtime APIs. We can move those runtime APIs definitions to primitives, but I would prefer to do it in a separate PR since this one is pretty verbose already.

And maybe related to I am using a fork, many polkadot-sdk creates are pulled twice such as sp-std due to deps to creates at paritytech/arkworks-substrate

I guess this is normal since probably both versions are needed.

…n-lib

skunert

Looks good and useful to me, nice work!

cumulus/polkadot-parachain/polkadot-parachain-lib/src/cli.rs

cumulus/polkadot-parachain/polkadot-parachain-lib/src/command.rs

cumulus/polkadot-parachain/src/chain_spec/mod.rs

cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/chain_spec.rs

Related to: #5210 Follow-up for #5288, as per this comment: #5288 (comment) I hope I understood this correctly.

serban300 added the T0-node This PR/Issue is related to the topic “node”. label Aug 8, 2024

serban300 self-assigned this Aug 8, 2024

serban300 force-pushed the polkadot-parachain-lib branch 2 times, most recently from f77f319 to be75466 Compare August 8, 2024 16:14

Support customizations

5061e06

serban300 force-pushed the polkadot-parachain-lib branch from be75466 to f18d191 Compare August 8, 2024 16:59

Separate lib from bin

650f007

serban300 force-pushed the polkadot-parachain-lib branch from f18d191 to 650f007 Compare August 8, 2024 17:54

serban300 marked this pull request as ready for review August 9, 2024 06:53

serban300 requested a review from a team as a code owner August 9, 2024 06:53

paritytech-review-bot bot requested a review from a team August 9, 2024 06:54

serban300 mentioned this pull request Aug 9, 2024

omni node without embedded chainspecs #5210

Closed

kianenigma reviewed Aug 9, 2024

View reviewed changes

cumulus/polkadot-parachain/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Aug 9, 2024

View reviewed changes

umbrella/src/lib.rs Outdated Show resolved Hide resolved

kianenigma approved these changes Aug 9, 2024

View reviewed changes

kianenigma mentioned this pull request Aug 9, 2024

polkadot-parachain: Add omni-node variant with u64 block number #5269

Merged

bkchr reviewed Aug 12, 2024

View reviewed changes

cumulus/polkadot-parachain/Cargo.toml Outdated Show resolved Hide resolved

serban300 added 5 commits August 12, 2024 11:50

Docs

6e233bb

Move lib to separate crate

75fecd1

Merge branch 'master' into polkadot-parachain-lib

3bb5211

Fix build

d58d28f

PRdoc

0a4b113

serban300 added 2 commits August 12, 2024 14:16

Fix PRdoc

3ee572b

Fix rust doc

75fa0e4

xlc reviewed Aug 13, 2024

View reviewed changes

cumulus/polkadot-parachain/Cargo.toml Outdated Show resolved Hide resolved

xlc reviewed Aug 13, 2024

View reviewed changes

cumulus/polkadot-parachain/polkadot-parachain-lib/Cargo.toml Outdated Show resolved Hide resolved

xlc reviewed Aug 13, 2024

View reviewed changes

cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/chain_spec.rs Outdated Show resolved Hide resolved

xlc reviewed Aug 13, 2024

View reviewed changes

cumulus/polkadot-parachain/polkadot-parachain-lib/src/cli.rs Outdated Show resolved Hide resolved

serban300 added 4 commits August 14, 2024 14:02

small fixes

4027fe3

Move RelayChainCli related logic under cli.rs

d4139a4

add CliConfig

728ad10

small changes

de75e86

CommandConfig -> RunConfig copyright start year -> u16

serban300 added 3 commits August 14, 2024 16:46

Merge remote-tracking branch 'upstream/master' into polkadot-parachai…

961e2ef

…n-lib

Update docs

d277c0a

Merge branch 'master' into polkadot-parachain-lib

7fa4f1e

skunert approved these changes Aug 21, 2024

View reviewed changes

serban300 added 2 commits August 21, 2024 17:51

Address CR comments

a9a7cde

Merge branch 'master' into polkadot-parachain-lib

8f5323e

serban300 added this pull request to the merge queue Aug 21, 2024

Merged via the queue into paritytech:master with commit 5ca3d2e Aug 21, 2024
188 of 189 checks passed

serban300 deleted the polkadot-parachain-lib branch August 21, 2024 16:03

serban300 mentioned this pull request Aug 27, 2024

polkadot-parachain-bin: Remove contracts parachain #5471

Merged

github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024

polkadot-parachain-bin: Remove contracts parachain (#5471)

38fce08

Related to: #5210 Follow-up for #5288, as per this comment: #5288 (comment) I hope I understood this correctly.

serban300 mentioned this pull request Sep 3, 2024

polkadot-omni-node: avoid frame-* and pallet-* dependencies in polkadot-parachain-lib #5569

Open

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

polkadot-parachain: compile separate lib and bin #5288

polkadot-parachain: compile separate lib and bin #5288

serban300 commented Aug 8, 2024 •

edited

Loading

kianenigma Aug 9, 2024

pgherveou Aug 23, 2024

kianenigma Aug 23, 2024

serban300 Aug 27, 2024

kianenigma left a comment •

edited

Loading

paritytech-cicd-pr commented Aug 12, 2024

xlc Aug 13, 2024

serban300 Aug 14, 2024

xlc Aug 13, 2024

serban300 Aug 14, 2024

xlc commented Aug 13, 2024 •

edited

Loading

xlc left a comment

serban300 commented Aug 14, 2024

serban300 commented Aug 14, 2024

skunert left a comment

polkadot-parachain: compile separate lib and bin #5288

polkadot-parachain: compile separate lib and bin #5288

Conversation

serban300 commented Aug 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kianenigma left a comment • edited Loading

Choose a reason for hiding this comment

paritytech-cicd-pr commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xlc commented Aug 13, 2024 • edited Loading

xlc left a comment

Choose a reason for hiding this comment

serban300 commented Aug 14, 2024

serban300 commented Aug 14, 2024

skunert left a comment

Choose a reason for hiding this comment

serban300 commented Aug 8, 2024 •

edited

Loading

kianenigma left a comment •

edited

Loading

xlc commented Aug 13, 2024 •

edited

Loading