Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small nits found accidentally along the way #5341

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Small nits found accidentally along the way #5341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b770c8
XCM doc nit
bkontur Aug 13, 2024
0d26aad
Removed unused deps found on the way
bkontur Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions cumulus/primitives/aura/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,14 @@ description = "Core primitives for Aura in Cumulus"
workspace = true

[dependencies]
codec = { features = ["derive"], workspace = true }

# Substrate
sp-api = { workspace = true }
sp-consensus-aura = { workspace = true }
sp-runtime = { workspace = true }

# Polkadot
polkadot-core-primitives = { workspace = true }
polkadot-primitives = { workspace = true }

[features]
default = ["std"]
std = [
"codec/std",
"polkadot-core-primitives/std",
"polkadot-primitives/std",
"sp-api/std",
"sp-consensus-aura/std",
"sp-runtime/std",
]
4 changes: 0 additions & 4 deletions cumulus/primitives/parachain-inherent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ scale-info = { features = ["derive"], workspace = true }
# Substrate
sp-core = { workspace = true }
sp-inherents = { workspace = true }
sp-runtime = { optional = true, workspace = true }
sp-state-machine = { optional = true, workspace = true }
sp-trie = { workspace = true }

# Cumulus
Expand All @@ -33,7 +31,5 @@ std = [
"scale-info/std",
"sp-core/std",
"sp-inherents/std",
"sp-runtime?/std",
"sp-state-machine?/std",
"sp-trie/std",
]
5 changes: 0 additions & 5 deletions cumulus/primitives/utility/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ log = { workspace = true }

# Substrate
frame-support = { workspace = true }
sp-io = { workspace = true }
sp-runtime = { workspace = true }
pallet-asset-conversion = { workspace = true }

# Polkadot
polkadot-runtime-common = { workspace = true }
polkadot-runtime-parachains = { workspace = true }
xcm = { workspace = true }
xcm-executor = { workspace = true }
xcm-builder = { workspace = true }
Expand All @@ -38,8 +36,6 @@ std = [
"log/std",
"pallet-asset-conversion/std",
"polkadot-runtime-common/std",
"polkadot-runtime-parachains/std",
"sp-io/std",
"sp-runtime/std",
"xcm-builder/std",
"xcm-executor/std",
Expand All @@ -51,7 +47,6 @@ runtime-benchmarks = [
"frame-support/runtime-benchmarks",
"pallet-asset-conversion/runtime-benchmarks",
"polkadot-runtime-common/runtime-benchmarks",
"polkadot-runtime-parachains/runtime-benchmarks",
"sp-runtime/runtime-benchmarks",
"xcm-builder/runtime-benchmarks",
"xcm-executor/runtime-benchmarks",
Expand Down
2 changes: 1 addition & 1 deletion polkadot/xcm/xcm-executor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ impl<Config: config::Config> XcmExecutor<Config> {
};
let actual_weight = maybe_actual_weight.unwrap_or(weight);
let surplus = weight.saturating_sub(actual_weight);
// We assume that the `Config::Weigher` will counts the `require_weight_at_most`
// We assume that the `Config::Weigher` will count the `require_weight_at_most`
// for the estimate of how much weight this instruction will take. Now that we know
// that it's less, we credit it.
//
Expand Down
Loading