Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Para Inherent: filter v2 candidate descriptors #5362

Merged
merged 14 commits into from
Aug 22, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Aug 14, 2024

On top of #5322

This is an additional check to prevent nodes from passing the v2 candidate descriptors in the runtime until it is enabled via the node feature.

TODO:

  • PRDoc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7015977

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

.
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim self-assigned this Aug 20, 2024
…lkadot-sdk into sandreim/filter_v2_descriptors
@alindima
Copy link
Contributor

I think you can merge this, since it's on the other branch also and it's hard to review without the context of the primitives PR.
Others can review it on that PR

@sandreim sandreim merged commit 1db5eb0 into sandreim/rfc103-primitives Aug 22, 2024
181 of 189 checks passed
@sandreim sandreim deleted the sandreim/filter_v2_descriptors branch August 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Audit
Development

Successfully merging this pull request may close these issues.

3 participants