Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge zombienet tests: remove old command #5434

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Aug 21, 2024

Related to: #3176

This PR:

  • migrates test 0003 to the new bridges zombienet tests command
    This test didn't work before and it still doesn't work. It was added at a time when we couldn't run it because we didn't have the scafolding. It needs to be fixed. For the moment we keep it in the repo as it is since the idea has value. But we don't run it in the CI. We can also decide to remove it in the future
  • removes the old command for running bridge zombienet tests
  • updates the README

@serban300 serban300 added T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges. labels Aug 21, 2024
@serban300 serban300 self-assigned this Aug 21, 2024
@serban300 serban300 requested a review from a team as a code owner August 21, 2024 13:26
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 21, 2024 13:27
@serban300 serban300 added the R0-silent Changes should not be mentioned in any release notes label Aug 21, 2024
@pepoviola
Copy link
Contributor

Hi @serban300, could be check if we can migrate those test to use the new sdk?

@serban300
Copy link
Contributor Author

Hi @pepoviola ! In the long run probably we'll want to migrate them to the new SDK, but it's a matter of prioritization. Right now we don't have the bandwidth to do it and probably it's a low priority issue.

@acatangiu acatangiu added this pull request to the merge queue Aug 28, 2024
Merged via the queue into paritytech:master with commit edd6f71 Aug 28, 2024
248 of 253 checks passed
ordian added a commit that referenced this pull request Aug 29, 2024
* master: (39 commits)
  short-term fix for para inherent weight overestimation (#5082)
  CI: Add backporting bot (#4795)
  Fix benchmark failures when using `insecure_zero_ed` flag (#5354)
  Command bot GHA v2 - /cmd <cmd> (#5457)
  Remove pallet::getter usage from treasury (#4962)
  Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
  Bump rustversion from 1.0.14 to 1.0.17 (#5405)
  Bridge zombienet tests: remove old command (#5434)
  polkadot-parachain: Add omni-node variant with u64 block number (#5269)
  Refactor verbose test (#5506)
  Use umbrella crate for minimal template (#5155)
  IBP Coretime Polkadot bootnodes (#5499)
  rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
  Update approval-voting-regression-bench (#5504)
  change try-runtime rpc domains (#5443)
  polkadot-parachain-bin: Remove contracts parachain (#5471)
  Add feature to allow Aura collator to use full PoV size (#5393)
  Adding stkd bootnodes (#5470)
  Make `PendingConfigs` storage item public (#5467)
  frame-omni-bencher maintenance (#5466)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants