Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkadot-parachain: add manual seal support #5586

Merged
merged 15 commits into from
Oct 2, 2024
Merged

polkadot-parachain: add manual seal support #5586

merged 15 commits into from
Oct 2, 2024

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Sep 4, 2024 •
edited
Loading

Resolves #5026

This PR adds support for starting a dev node with manual seal consensus. This can be done by using the --dev-block-time argument . For example:

polkadot-parachain --chain asset-hub-rococo-dev --dev-block-time 5000 --tmp

@serban300 serban300 added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. labels Sep 4, 2024
@serban300 serban300 self-assigned this Sep 4, 2024
@serban300 serban300 force-pushed the polkadot-parachain-manual-seal branch from d283731 to bc89536 Compare September 4, 2024 11:37
@serban300 serban300 force-pushed the polkadot-parachain-manual-seal branch from bc89536 to 0c8a994 Compare September 4, 2024 11:50
@paritytech paritytech deleted a comment from paritytech-cicd-pr Sep 4, 2024
skunert
skunert reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not look at the manual_seal.rs code itself yet, will make one more pass.

cumulus/polkadot-parachain/polkadot-parachain-lib/src/cli.rs Outdated Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/mod.rs Outdated Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/mod.rs Outdated Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/nodes/shell.rs Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/nodes/mod.rs Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/command.rs Outdated Show resolved Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/command.rs Show resolved Hide resolved
skunert
skunert approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

kianenigma
kianenigma approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all open discussions are well addressed and closed :)

@serban300 serban300 mentioned this pull request Oct 2, 2024
Closed
@kianenigma
Copy link
Contributor

Final request: PR description also seems out of date wrt example 🙏

@serban300
Copy link
Contributor Author

Final request: PR description also seems out of date wrt example 🙏

Sorry, missed it. Done.

@serban300 serban300 mentioned this pull request Oct 2, 2024
Open
@serban300 serban300 added this pull request to the merge queue Oct 2, 2024
Merged via the queue into paritytech:master with commit 3cf83ca Oct 2, 2024
217 of 218 checks passed
@serban300 serban300 deleted the polkadot-parachain-manual-seal branch October 2, 2024 15:05
@serban300 serban300 mentioned this pull request Oct 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 4, 2024
@serban300
polkadot-parachain: Remove shell node (#5911)
261b3da 
Removing the shell node variant for the polkadot-parachain as discussed
here:
#5586 (comment)

Resolves #5898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skunert skunert skunert approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees

@serban300 serban300

Labels
R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omni-node: add support for starting a dev chain with manual seal
3 participants
@serban300 @kianenigma @skunert