PVF: drop backing jobs if it is too late #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
sandreim
reviewed
Nov 6, 2024
alindima
reviewed
Nov 6, 2024
sandreim
approved these changes
Nov 6, 2024
Comment on lines
+331
to
+335
| if in_active_fork { | ||
| None | ||
| } else { | ||
| Some(index) | ||
| } |
There was a problem hiding this comment.
We could directly filter on the queue, so if in active fork we send ValidationError::ExecutionDeadline and return true otherwise false.
There was a problem hiding this comment.
I can't send the result inside the closure, that why I didn't use retain
There was a problem hiding this comment.
why not? the send function is not async and we ignore the result
alindima
approved these changes
Nov 7, 2024
paritytech-ci
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fixes #5530 This PR introduces the removal of backing jobs that have been back pressured for longer than `allowedAncestryLen`, as these candidates are no longer viable. It is reasonable to expect a result for a backing job execution within `allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay block number and synchronize the validation host by sending activated leaves. --------- Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5530
This PR introduces the removal of backing jobs that have been back pressured for longer than
allowedAncestryLen, as these candidates are no longer viable.It is reasonable to expect a result for a backing job execution within
allowedAncestryLenblocks. Therefore, we set the job TTL as a relay block number and synchronize the validation host by sending activated leaves.