Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-utility: Improve weight annotations #5644

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 9, 2024

Prevent allocations when calculating the weights.

Prevent allocations when calculating the weights.
@bkchr bkchr added the T2-pallets This PR/Issue is related to a particular pallet. label Sep 9, 2024
@bkchr bkchr requested a review from a team as a code owner September 9, 2024 09:09
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ggwpez
Copy link
Member

ggwpez commented Sep 9, 2024

PS going to start the prdoc bot.
PPS it was deleted in #5457 wtf

@ggwpez ggwpez added the A4-needs-backport Pull request must be backported to all maintained releases. label Sep 9, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit f4eb417 Sep 9, 2024
194 of 203 checks passed
@ggwpez ggwpez deleted the bkchr-pallet-utility-weight-improvements branch September 9, 2024 12:54
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
Prevent allocations when calculating the weights.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
(cherry picked from commit f4eb417)
Copy link

github-actions bot commented Sep 9, 2024

Successfully created backport PR for stable2407:

github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
Prevent allocations when calculating the weights.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
(cherry picked from commit f4eb417)
Copy link

github-actions bot commented Sep 9, 2024

Successfully created backport PR for stable2409:

ggwpez added a commit that referenced this pull request Sep 9, 2024
Backport #5644 into `stable2409` (cc @bkchr).

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added a commit that referenced this pull request Sep 9, 2024
Backport #5644 into `stable2407` (cc @bkchr).

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez removed the A4-needs-backport Pull request must be backported to all maintained releases. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants