rpc server: fix deny unsafe on RpcMethods::Auto #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
niklasad1
added
A1-insubstantial
niklasad1
added
the
A4-needs-backport
bkchr
approved these changes
Sep 11, 2024
ggwpez
approved these changes
Sep 11, 2024
|
/cmd prdoc --pr 5678 --audience "Node Operator" --bump patch |
|
Command "" has started 🚀 See logs here |
|
Command "" has finished ✅ See logs here |
niklasad1
added a commit
that referenced
this pull request
Sep 12, 2024
Close #5677 I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in #4792 Thus: - (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe - (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe --------- Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
ggwpez
added a commit
that referenced
this pull request
Sep 12, 2024
ggwpez
removed
the
A4-needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5677
I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in #4792
Thus: