Re-establish pallet_revive weights baseline

[mordamax]

• update baseline for pallet_revive
• update cmd pipeline name
• Fix compilation after renaming some of benchmarks in pallet_revive. [Runtime Dev]. Changed the "instr" benchmark so that it should no longer return to little weight. It is still bogus but at least benchmarking should not work. (by @athei )

[athei]

It doesn't compile because we renamed some benchmarks but never fixed the places where the benchmarks were used. The benchmarking worked fine I guess just need some follow up fixes here.

I can push the fixes to this PR later.

[athei]

So I fixed the compilation. But because the instr benchmark is so whacky it foes down to zero and we and up with divide by zero panics. Have to look into this later.

[athei]

/cmd bench --pallet=pallet_revive --runtime=dev

[athei]

I changed the instr benchmark so that it should no longer return to little weight. It is still bogus but at leats benchmarking should not work.

[athei]

Do you know why it didn't work?

[mordamax]

Do you know why it didn't work?

2024-09-28T12:33:05.093879Z  WARN frame_omni_bencher: The FRAME omni-bencher is not yet battle tested - double check the results.    
2024-09-28T12:33:05.094321Z  INFO frame_benchmarking_cli::pallet::command: Loading WASM from target/release/wbuild/kitchensink-runtime/kitchensink_runtime.wasm    
2024-09-28T12:33:10.291775Z ERROR frame_benchmarking_cli::pallet::command: Please pick one of the available presets with `--genesis-builder-preset=<PRESET>`. Available presets (0): []. Error: "The preset with name Some(\"development\") is not available."    
Error: Input("The preset with name Some(\"development\") is not available.")

investigating...

[mordamax]

/cmd bench --pallet=pallet_revive --runtime=dev --clean

[github-actions]

Command "bench --pallet=pallet_revive --runtime=dev --clean" has started 🚀 See logs here

[github-actions]

Command "bench --pallet=pallet_revive --runtime=dev --clean" has started 🚀 See logs here

[github-actions]

Command "bench --pallet=pallet_revive --runtime=dev --clean" has failed ❌! See logs here

[mordamax]

bot bench substrate-pallet --pallet=pallet_revive

[command-bot]

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-bd6f18d0-4fc7-4f2e-940c-2310663c6b44 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_revive has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7477550/artifacts/download.

[athei]

Why are those flaky tests required again? It is really starting to get annoying.