Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #5753 #5874

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Commits on Sep 30, 2024

  1. Use maximum allowed response size for request/response protocols (#5753)

    # Description
    
    Adjust the PoV response size to the default values used in the
    substrate.
    Fixes #5503
    
    ## Integration
    
    The changes shouldn't impact downstream projects since we are only
    increasing the limit.
    
    ## Review Notes
    
    You can't see it from the changes, but it affects all protocols that use
    the `POV_RESPONSE_SIZE` constant.
    - Protocol::ChunkFetchingV1
    - Protocol::ChunkFetchingV2
    - Protocol::CollationFetchingV1
    - Protocol::CollationFetchingV2
    - Protocol::PoVFetchingV1
    - Protocol::AvailableDataFetchingV1
    
    ## Increasing timeouts
    
    https://github.com/paritytech/polkadot-sdk/blob/fae15379cba0c876aa16c77e11809c83d1db8f5c/polkadot/node/network/protocol/src/request_response/mod.rs#L126-L129
    
    I assume the current PoV request timeout is set to 1.2s to handle 5
    consecutive requests during a 6s block. This setting does not relate to
    the PoV response size. I see no reason to change the current timeouts
    after adjusting the response size.
    
    However, we should consider networking speed limitations if we want to
    increase the maximum PoV size to 10 MB. With the number of parallel
    requests set to 10, validators will need the following networking
    speeds:
    - 5 MB PoV: at least 42 MB/s, ideally 50 MB/s.
    - 10 MB PoV: at least 84 MB/s, ideally 100 MB/s.
    
    The current required speed of 50 MB/s aligns with the 62.5 MB/s
    specified [in the reference hardware
    requirements](https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot#reference-hardware).
    Increasing the PoV size to 10 MB may require a higher networking speed.
    
    ---------
    
    Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
    (cherry picked from commit 0c9d8fe)
    AndreiEres authored and github-actions[bot] committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e8a416b View commit details
    Browse the repository at this point in the history