Adds multi-block election types and refactors current pallets to support new interfaces and types #6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Ank4n
reviewed
Oct 15, 2024
Ank4n
reviewed
Oct 15, 2024
| fn elect(remaining: PageIndex) -> Result<BoundedSupportsOf<Self>, Self::Error>; | ||
|
|
||
| /// The index of the *most* significant page that this election provider supports. | ||
| fn msp() -> PageIndex { |
There was a problem hiding this comment.
may be call it highest page or top page?
There was a problem hiding this comment.
Also, since the current page index needs to be stored somewhere, could we just store it on ElectionProvider, and Staking then can just call next_elect()?
There was a problem hiding this comment.
I think I called it like this initially be be simiar to the concept if msp (most significant bit) in cpus.
…into gpestana/epm-mb
This was referenced Oct 18, 2024
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
…into gpestana/epm-mb
gui1117
reviewed
Nov 14, 2024
| // default bounds are unbounded. | ||
| let targets = | ||
| T::DataProvider::electable_targets(DataProviderBounds::default(), Zero::zero())?; | ||
| let voters = T::DataProvider::electing_voters(DataProviderBounds::default(), Zero::zero())?; |
There was a problem hiding this comment.
we can introduce a function unbounded to DataProviderBounds to make code more readable.
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This was referenced Nov 15, 2024
gpestana
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the types and structs required to run a mulit-block election and updates the EPM, staking-pallet and all dependent pallets to use the multi-block types. The Westend runtime is configured to run a 1 paged election, which is a noop refactor compared to the current single-block election.
Notable changes since last reviews:
Tasks based on feedback that can be closed after merging this PR: Umbrella ticket for multi-block election tasks to improve after PR#6034.
The multi-block election provider pallet is wip and it's added in a separate PR (#6213).
To-do before merging:
on_intializein pallet staking