Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inclusion emulator: correctly handle UMP signals #6178

Merged
merged 152 commits into from
Nov 4, 2024
Merged

inclusion emulator: correctly handle UMP signals #6178

merged 152 commits into from
Nov 4, 2024

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Oct 22, 2024 •
edited
Loading

Changes inclusion emulator to not count the UMP signals when checking ump message constraints.

@sandreim
WIP primitives
793142e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
WIP
3a29fdf 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Working version.
4a53577 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Better version
8285ae7 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Add missing primitives and fix things
2831c5e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Implement v2 receipts in polkadot-runtime-parachains
c767d60 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add missing stuff
96999e3 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Switch parachains runtime to use new primitives
c5f2dc3 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
use vstaging primitives
dbb0160 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
update rococo and westend
5efab68 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
client keeps using the old primitives
c2232e4 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
no unsafe pls
87b079f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
move async backing primtiives to own file
00e8c13 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix
cd4d02f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix test build
5509e33 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix test-runtime
f8b86d2 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
self review feedback
fe2fbfb 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
review feedback
975e13b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
feedback
1c7ac55 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
feedback
653873b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
clippy
dc98149 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
chores
0a6bce3 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Filter v2 candidate descriptors
5e4dac2 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix
f12ca7a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix prospective parachains tests
13734de 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix fix
effb1cc 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt
3f75cba 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix comment
75a47bb 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
another one
12ed853 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix build
f2c0882 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim and others added 8 commits October 17, 2024 17:55
@sandreim
fmt and feedback
320318a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
more fixes
dfde71f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
delete PRDoc
cb93bb6 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@actions-user
Update from sandreim running command 'prdoc --audience node_dev runti…
a402509 
…me_dev --bump major'
@sandreim
adjust generated PRDoc
6371454 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix build again
9c5097d 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix test
b2818f3 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix inclusion emulator
0bab530 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Oct 22, 2024
@alindima alindima mentioned this pull request Oct 23, 2024
Closed
@sandreim
typo
77e1925 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
alindima
alindima reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a prdoc and remove the silent label

polkadot/node/subsystem-util/src/inclusion_emulator/mod.rs Show resolved Hide resolved
polkadot/node/subsystem-util/src/inclusion_emulator/mod.rs Outdated Show resolved Hide resolved
Base automatically changed from sandreim/node_v2_descriptors to master October 25, 2024 16:12
@sandreim
feedback
a61683b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
c338ed3 
…reim/fix_inclusion_emulator

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix cargo toml
7147793 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit b326540 Nov 4, 2024
195 of 198 checks passed
@sandreim sandreim deleted the sandreim/fix_inclusion_emulator branch November 4, 2024 14:09
ordian added a commit that referenced this pull request Nov 5, 2024
@ordian
Merge branch 'master' into ao-fix-issue-64
9ea2099 
* master: (129 commits)
  pallet-revive: Use `RUSTUP_TOOLCHAIN` if set (#6365)
  [eth-rpc] proxy /health (#6360)
  [Release|CI/CD] adjust release pipelines (#6366)
  Bump the known_good_semver group across 1 directory with 3 updates (#6339)
  Run check semver in MQ (#6287)
  [Deprecation] deprecate treasury `spend_local` call and related items (#6169)
  refactor and harden check_core_index (#6217)
  litep2p: Update litep2p to v0.8.0 (#6353)
  [pallet-staking] Additional check for virtual stakers (#5985)
  migrate pallet-remarks to v2 bench syntax (#6291)
  Remove leftover references of Wococo (#6361)
  snowbridge: allow account conversion for Ethereum accounts (#6221)
  authority-discovery: Populate DHT records with public listen addresses (#6298)
  Bounty Pallet: add `approve_bounty_with_curator` call to `bounties` pallet (#5961)
  Silent annoying log (#6351)
  [pallet-revive] rework balance transfers (#6187)
  `statement-distribution`: RFC103 implementation (#5883)
  Disable flaky tests reported in #6343 / #6345 (#6346)
  migrate pallet-recovery to benchmark V2 syntax (#6299)
  inclusion emulator: correctly handle UMP signals (#6178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alindima alindima alindima approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandreim @ordian @alindima @actions-user