Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and test events in pallet-conviction-voting #6544

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Nov 19, 2024

Description

#4613 introduced events for pallet_conviction_voting::{vote, remove_vote, remove_other_vote}.
However:

  1. it did not include unlock
  2. the pallet's unit tests were missing an update

Integration

N/A

Review Notes

This is as #6261 was, so it is a trivial change.

@rockbmb rockbmb added I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests. T14-system_parachains This PR/Issue is related to system parachains. labels Nov 19, 2024
@rockbmb rockbmb self-assigned this Nov 19, 2024
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/11919110613
Failed job name: fmt

@rockbmb rockbmb marked this pull request as ready for review November 19, 2024 19:12
@rockbmb rockbmb requested a review from a team as a code owner November 19, 2024 19:12
@rockbmb rockbmb added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit ca8beae Nov 20, 2024
222 of 301 checks passed
@rockbmb rockbmb deleted the pallet-conviction-voting-missing-events branch November 20, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests. T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants