Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for 'Add missing fields to the light sync state #7225' #1801

Merged
5 commits merged into from
Oct 15, 2020
Merged

Companion PR for 'Add missing fields to the light sync state #7225' #1801

5 commits merged into from
Oct 15, 2020

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Oct 9, 2020

@expenses expenses added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Oct 9, 2020
@expenses expenses mentioned this pull request Oct 9, 2020
Merged
@expenses
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Oct 15, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Oct 15, 2020

Checks failed; merge aborted.

@tomaka
Copy link
Contributor

tomaka commented Oct 15, 2020

I think you weren't supposed to comment "bot merge" here. The "bot merge" in Substrate started the merging here as well.

@ghost ghost merged commit 9190eb6 into master Oct 15, 2020
@ghost ghost deleted the ashley-improve-sync-state branch October 15, 2020 10:28
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomaka tomaka tomaka approved these changes

@andresilva andresilva andresilva approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expenses @tomaka @andresilva