Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert "revert enabling authority discovery by default (#1532)" #1807

Merged
1 commit merged into from
Oct 13, 2020

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Oct 12, 2020

This reverts commit 671cc75.

The authority discovery module was initially enabled by default on validator and sentry nodes with commit bc6e1e7. This change was later on reverted in 671cc75. With this commit the authority discovery module is again enabled by default.

With libp2p/rust-libp2p#1698 the amount of file descriptors needed for the authority discovery Kademlia DHT activities has been drastically reduced. With paritytech/substrate#7018 lookups are spread out instead of done all at once removing any spikes in number of file descriptors, network traffic or CPU usage.

After a testing phase on a couple of our Kusama validator and sentry nodes the authority discovery module is now enabled on the majority of Parity Kusama nodes. For details see either paritytech/substrate#7018 (comment) or consult the corresponding authority discovery Grafana dashboard.

Closes #1544.

Release note suggestion:

The authority discovery module enables Polkadot authorities to discover and directly connect to other authorities. Instead of having to explicitly enable the authority discovery module on validator and sentry nodes, with this release the module is enabled by default. For those not interested in running the authority module please pass the ---disable-authority-discovery flag. As one would expect the --enable-authority-discovery flag is replaced by the the --disable-authority-discovery flag.

This reverts commit 671cc75.

The authority discovery module was initially enabled by default on
validator and sentry nodes with commit bc6e1e7. This change was later on
reverted in 671cc75. With this commit the authority discovery module is
again enabled by default.
@mxinden mxinden added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. labels Oct 12, 2020
@tomaka
Copy link
Contributor

tomaka commented Oct 13, 2020

bot merge

@ghost
Copy link

ghost commented Oct 13, 2020

Trying merge.

@ghost ghost merged commit 97fe016 into master Oct 13, 2020
@ghost ghost deleted the mxinden-auth-disc-default-2 branch October 13, 2020 12:09
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert reversion of authority-discovery enabling
3 participants