This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make collator::Network require Send + Sync to make it work
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
approved these changes
Jul 5, 2019
andresilva
reviewed
Jul 5, 2019
| @@ -47,6 +47,8 @@ const GENESIS_BODY: AdderBody = AdderBody { | |||
| #[derive(Clone)] | |||
| struct AdderContext { | |||
| db: Arc<Mutex<HashMap<AdderHead, AdderBody>>>, | |||
| /// We store it here to make sure that our interfaces require the correct bounds. | |||
There was a problem hiding this comment.
If I understand correctly this is done to make sure our instance of Network is Send + Sync.
There was a problem hiding this comment.
Yeah, the code compiled before, but while integrating it into Cumulus the compiler denied it :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.