This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Improve xcm-simulator #3546
Closed
Improve xcm-simulator #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunxw
reviewed
Aug 1, 2021
…eived messages for testing purposes and to test QueryHolding as a success response message
4meta5
commented
Aug 2, 2021
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
|
Just merged #2815 into this branch, it'll be easier to review this PR again once that PR is merged into master |
|
Ah I keep getting wrecked by auto-merge 😬 I'll open a new one |
|
superseded by #3618 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests from #3537 to xcm-simulator (except teleport_assets)
Also makes message processing asynchronous and pulls it out from the test externalities environment to allow for the processing of messages that go back to the origin chain. The previous implementation ran into borrowing issues in the underlying
RefCells when sending messages back to the origin.Messages are processed after the closure passed to
test_ext.execute_with().