This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add tests and modify as_vec implementation #3715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lldenaurois
added
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Aug 24, 2021
Lldenaurois
commented
Aug 24, 2021
Lldenaurois
commented
Aug 24, 2021
Lldenaurois
commented
Aug 24, 2021
Lldenaurois
force-pushed
the
erasure_chunk_patch
branch
from
August 25, 2021 07:23
e13242b
to
4bbbee8
Compare
Lldenaurois
added
the
B0-silent
Changes should not be mentioned in any release notes
label
Aug 25, 2021
ordian
removed
the
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
label
Aug 25, 2021
Lldenaurois
force-pushed
the
erasure_chunk_patch
branch
from
August 25, 2021 18:47
8319192
to
d161779
Compare
Lldenaurois
force-pushed
the
erasure_chunk_patch
branch
from
August 25, 2021 18:50
d161779
to
d58a7f3
Compare
eskimor
reviewed
Aug 26, 2021
Lldenaurois
force-pushed
the
erasure_chunk_patch
branch
from
September 6, 2021 10:16
0920904
to
cfbd14a
Compare
eskimor
approved these changes
Sep 6, 2021
ordian
reviewed
Sep 6, 2021
@@ -23,3 +23,6 @@ serde = { version = "1.0.130", features = ["derive"] } | |||
|
|||
[target.'cfg(not(target_os = "unknown"))'.dependencies] | |||
zstd = "0.6.0" | |||
|
|||
[dev-dependencies] | |||
polkadot-erasure-coding = { path = "../../erasure-coding" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that still needed?
ordian
added a commit
that referenced
this pull request
Sep 6, 2021
* master: Add tests and modify as_vec implementation (#3715) Bump structopt from 0.3.22 to 0.3.23 (#3770) bump substrate and beefy (#3789) set `DisputesHandler` in initializer (#3788) Bump futures from 0.3.16 to 0.3.17 (#3742) Convert rococo chainspec to raw chainspec (#3785) feat/overseer: introduce closure init (#3775) comment out bridges runtime modules (broken) and update Rococo chain-spec (#3780) Add VoteLocking config (#3734) Enable disputes on rococo (#3764) XCM: Automatic Version Negotiation (#3736)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to address feedback left in #3626
Closes #3670