Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

custom cargo profiles for production #4627

Merged
merged 9 commits into from
Dec 29, 2021
Merged

Conversation

ordian
Copy link
Member

@ordian ordian commented Dec 28, 2021

Step towards #4311.

The testnet profile is useful for https://github.com/paritytech/devops/issues/1221.

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 28, 2021
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the pr description, because it doesn't fixes the issue entirely. We still need to change the release build to use the new profile + mentioning it everywhere in docs etc.

* master:
  Add Parachain Grafana dashboards (#4578)
  collation-gen: don't hash validation code (#4628)
  runtime-api: add validation_code_hash API (#4629)
@ordian ordian requested a review from a team as a code owner December 28, 2021 20:44
@ordian ordian requested a review from chevdor as a code owner December 29, 2021 08:10
@ordian
Copy link
Member Author

ordian commented Dec 29, 2021

I've reverted f1d1549 because apparently the build_type

polkadot/cli/build.rs

Lines 18 to 20 in b25f8c5

if let Ok(profile) = std::env::var("PROFILE") {
println!("cargo:rustc-cfg=build_type=\"{}\"", profile);
}

is set to release even with --profile testnet.

One consideration is that with debug symbols the binary size increases significantly, which might cause some issues in CI (like https://gitlab.parity.io/parity/polkadot/-/jobs/1310366), but hopefully, we can work around them.

@ordian
Copy link
Member Author

ordian commented Dec 29, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1335855 into master Dec 29, 2021
@paritytech-processbot paritytech-processbot bot deleted the ao-rococo-profile branch December 29, 2021 14:10
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Dec 31, 2021
jasl added a commit to Phala-Network/phala-blockchain that referenced this pull request Dec 31, 2021
drahnr pushed a commit that referenced this pull request Jan 4, 2022
* add custom profiles and specify MSVR as 1.57

* fix host-perf-check command

* use testnet profile for CI images

* do not do lto for testnet profile

* fix artifact path

* test with testnet profile to reuse build artifacts

* Revert "fix host-perf-check command"

This reverts commit f1d1549.

* bump zombienet version

Co-authored-by: Javier Viola <javier@parity.io>
@ordian ordian mentioned this pull request Jan 19, 2022
16 tasks
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
* add custom profiles and specify MSVR as 1.57

* fix host-perf-check command

* use testnet profile for CI images

* do not do lto for testnet profile

* fix artifact path

* test with testnet profile to reuse build artifacts

* Revert "fix host-perf-check command"

This reverts commit f1d1549.

* bump zombienet version

Co-authored-by: Javier Viola <javier@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants