This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Dec 28, 2021
ordian
force-pushed
the
ao-rococo-profile
branch
from
December 28, 2021 17:00
f230210
to
f1d1549
Compare
pepyakin
approved these changes
Dec 28, 2021
bkchr
approved these changes
Dec 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the pr description, because it doesn't fixes the issue entirely. We still need to change the release build to use the new profile + mentioning it everywhere in docs etc.
This reverts commit f1d1549.
I've reverted Lines 18 to 20 in b25f8c5
is set to One consideration is that with debug symbols the binary size increases significantly, which might cause some issues in CI (like https://gitlab.parity.io/parity/polkadot/-/jobs/1310366), but hopefully, we can work around them. |
bot merge |
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Dec 31, 2021
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Dec 31, 2021
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
* add custom profiles and specify MSVR as 1.57 * fix host-perf-check command * use testnet profile for CI images * do not do lto for testnet profile * fix artifact path * test with testnet profile to reuse build artifacts * Revert "fix host-perf-check command" This reverts commit f1d1549. * bump zombienet version Co-authored-by: Javier Viola <javier@parity.io>
16 tasks
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* add custom profiles and specify MSVR as 1.57 * fix host-perf-check command * use testnet profile for CI images * do not do lto for testnet profile * fix artifact path * test with testnet profile to reuse build artifacts * Revert "fix host-perf-check command" This reverts commit f1d1549. * bump zombienet version Co-authored-by: Javier Viola <javier@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards #4311.
The testnet profile is useful for https://github.com/paritytech/devops/issues/1221.