Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

wrong if-case #4798

Merged
merged 4 commits into from
Jan 28, 2022
Merged

wrong if-case #4798

merged 4 commits into from
Jan 28, 2022

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Jan 27, 2022

No description provided.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 27, 2022
@drahnr drahnr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 27, 2022
@drahnr drahnr self-assigned this Jan 27, 2022
@drahnr drahnr requested review from ordian and eskimor January 27, 2022 18:13
@drahnr drahnr requested a review from sandreim January 27, 2022 18:20
@drahnr drahnr added this to the v0.9.16 milestone Jan 27, 2022
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo tests that need to be fixed

@drahnr
Copy link
Contributor Author

drahnr commented Jan 27, 2022

CI tests all got cancelled for unknown reason, they did not fail.

chevdor pushed a commit that referenced this pull request Jan 28, 2022
@chevdor
Copy link
Contributor

chevdor commented Jan 28, 2022

Removing this PR from the milestone as we already have #4800 in there.

@chevdor chevdor removed this from the v0.9.16 milestone Jan 28, 2022
ordian added a commit that referenced this pull request Jan 28, 2022
…or_check_validation_outputs_release_v0916

* origin/wk-prep-v0.9.16-rc7:
  wrong if-case - backport of #4798 into v0.9.16 (#4800)
  Fix release profile (#4778)
  Update deps
@ordian
Copy link
Member

ordian commented Jan 28, 2022

needs a merge with master

@chevdor chevdor mentioned this pull request Jan 28, 2022
chevdor added a commit that referenced this pull request Jan 28, 2022
* Update deps

* Fix release profile (#4778)

* Add codeden-units=1

ref #4311

* opt-level to 3

* Fix opt-level

* Refactor apt-level into the release profile

fix #4780

* wrong if-case - backport of #4798 into v0.9.16 (#4800)

* fixup

* fmt

* fix tests

* Rk fix sorting 0.9.16 (#4806)

* Fix incomplete sorting.

* fmt.

* Better test.

* Update runtime/parachains/src/disputes.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* cargo fmt

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Refactor check validation outputs - Backport of #4727 into v0.9.16 (#4801)

* Move PersistedValidationData check into

* Address feedback

* Remove incorrect comment

* Update runtime/parachains/src/inclusion/mod.rs

* fmt

* Add logging

Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
Co-authored-by: Andronik <write@reusable.software>

Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Co-authored-by: Robert Klotzner <eskimor@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Lldenaurois <ljdenaurois@gmail.com>
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
Co-authored-by: Andronik <write@reusable.software>
@ordian ordian merged commit 1c2a0e2 into master Jan 28, 2022
@ordian ordian deleted the bernhard-fixup2 branch January 28, 2022 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants