Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate parachains runtime to Named Events #5450

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Migrate parachains runtime to Named Events #5450

wants to merge 14 commits into from

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented May 4, 2022 •
edited
Loading

follow up: #5422 about runtime/parachains @shawntabrizi

  • hrmp
  • ump
  • disputes
  • inclusion
  • paras

Polkadot address: 16AJoii4D1HmFvKVqPmPjcTsoVidmw5nUB74NF5rMVgFwpeA

@zqhxuyuan zqhxuyuan marked this pull request as ready for review May 5, 2022 04:12
@zqhxuyuan zqhxuyuan changed the title parachains named events Migrate parachains runtime to Named Events May 5, 2022
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 9, 2022
@bkchr bkchr requested a review from shawntabrizi May 9, 2022 08:02
@bizzyvinci bizzyvinci mentioned this pull request May 20, 2022
Merged
3 tasks
@bizzyvinci
Copy link
Contributor

bizzyvinci commented May 20, 2022 •
edited
Loading

Hi @zqhxuyuan. I notice some events have not being updated in runtime

  • common/src/assigned_slots
  • rococo/src/validator_manager
  • test-runtime/src/lib

I'm willing to make a PR to your branch if you wish.

@zqhxuyuan
Copy link
Contributor Author

@bizzyvinci No problem! Go ahead. 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zqhxuyuan @bizzyvinci @bkchr