Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Zombienet] update the image to the version 1.2.51 globally #5856

Merged
merged 4 commits into from
Aug 4, 2022
Merged

[Zombienet] update the image to the version 1.2.51 globally #5856

merged 4 commits into from
Aug 4, 2022

Conversation

pepoviola
Copy link
Contributor

Hi @sandreim, this rollback the global version to use the one that handle the undefined metrics cases.

Thanks!

@pepoviola pepoviola requested a review from a team as a code owner August 4, 2022 08:45
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 4, 2022
@paritytech-ci paritytech-ci requested a review from a team August 4, 2022 08:46
@pepoviola pepoviola added I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 4, 2022
@sandreim
Copy link
Contributor

sandreim commented Aug 4, 2022

This makes us use 3 diff versions . I assume this is temporary. I would prefer to use a single version that has all the issues fixed. Would be happy to help with fixing this .

@pepoviola
Copy link
Contributor Author

Hi @sandreim, yes this is just a temporary rollback, the goal is move all tests to latest version next week.
Thanks!

@pepoviola
Copy link
Contributor Author

Hi @sandreim, yes this is just a temporary rollback, the goal is move all tests to latest version next week. Thanks!

@sandreim, I will move this to v1.2.51 shortly.

@ordian
Copy link
Member

ordian commented Aug 4, 2022

Can we also unify

polkadot/.gitlab-ci.yml

Line 774 in b8e82ea

image: "docker.io/paritytech/zombienet:v1.2.49"

and

polkadot/.gitlab-ci.yml

Line 745 in b8e82ea

image: "docker.io/paritytech/zombienet:v1.2.45"

@pepoviola
Copy link
Contributor Author

Can we also unify

polkadot/.gitlab-ci.yml

Line 774 in b8e82ea

image: "docker.io/paritytech/zombienet:v1.2.49"

and

polkadot/.gitlab-ci.yml

Line 745 in b8e82ea

image: "docker.io/paritytech/zombienet:v1.2.45"

Sounds good, I updated those tests too.
Thanks!

@ordian ordian changed the title [Zombienet] rollback global version and use new version for beefy test [Zombienet] update the image to the version 1.2.51 globally Aug 4, 2022
@paritytech-ci paritytech-ci requested a review from a team August 4, 2022 12:38
@ordian
Copy link
Member

ordian commented Aug 4, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7079d23 into master Aug 4, 2022
@paritytech-processbot paritytech-processbot bot deleted the zombienet-rollback-version branch August 4, 2022 12:42
ordian added a commit that referenced this pull request Aug 5, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
3a2858d 
* master:
  [Zombienet] update the image to the version 1.2.51 globally (#5856)
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergejparity sergejparity sergejparity approved these changes

@sandreim sandreim sandreim approved these changes

@alvicsam alvicsam alvicsam approved these changes

@acatangiu acatangiu acatangiu approved these changes

@lovelaced lovelaced lovelaced approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I5-tests Tests need fixing, improving or augmenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pepoviola @sandreim @ordian @lovelaced @acatangiu @alvicsam @sergejparity