This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
E0-runtime_migration
PR introduces code that might require downstream chains to run a runtime upgrade.
labels
Aug 16, 2022
alvicsam
removed
the
E0-runtime_migration
PR introduces code that might require downstream chains to run a runtime upgrade.
label
Aug 17, 2022
alvicsam
changed the title
[WIP] Playground for check-runtime-migration
[ci] Add check-runtime-migration job
Aug 17, 2022
rdovgan
approved these changes
Aug 17, 2022
coderobe
approved these changes
Aug 17, 2022
EgorPopelyaev
approved these changes
Aug 17, 2022
sergejparity
approved these changes
Aug 17, 2022
radupopa2010
approved these changes
Aug 17, 2022
THANK YOU SIR. 🎩 ❤️ |
against which nodes are you running this? |
It runs on general ci-nodes. Should it be on |
ordian
added a commit
that referenced
this pull request
Aug 29, 2022
* master: (23 commits) Bump futures-util from 0.3.21 to 0.3.23 (#5922) Companion for 12095 (#5924) use generated preimage weight (#5904) Update Substrate to make companion check happy (#5934) Fix wrong logic. (#5931) update weights (#5911) Clean up MigrateToV10 (#5921) Bump async-trait from 0.1.56 to 0.1.57 (#5919) Send back empty votes + log in approval-voting in case candidate entry is missing. (#5925) chore: bump zombienet version (#5914) Bump indexmap from 1.9.0 to 1.9.1 (#5918) Bump proc-macro2 from 1.0.40 to 1.0.43 (#5878) Bump hyper from 0.14.19 to 0.14.20 (#5901) Fix output file for updating weights in run_benches_for_runtime.sh (#5906) Companion to Substrate PR 12006 (#5913) pin gha versions (#5916) Companion for new Trie cache (#5897) [ci] Add check-runtime-migration job (#5891) Governance 2 (Part 1, Non-Controversial Changes) (#5892) Added Dwellir bootnodes for Kusama and Polkadot (#5772) ...
Seems to be failing in #5930 |
If we can create a daily job that just generates snapshots for all 3 networks for try-runtime, and then use those files in the CI (and download links so developers can use them locally) that's speed up the CI a lot. |
Yes, but the job itself works correctly but tests failed: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1853827 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the
check-runtime-migration
job which runs unit tests for runtime migration (more info here: #5865). The job runs on every PR and checks if the PR has theE1-runtimemigration
label. If yes - the test is started.Log of the successful job can be found here
Closes https://github.com/paritytech/ci_cd/issues/573