Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[ci] Add check-runtime-migration job #5891

Merged
merged 6 commits into from
Aug 17, 2022
Merged

[ci] Add check-runtime-migration job #5891

merged 6 commits into from
Aug 17, 2022

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Aug 16, 2022

The PR adds the check-runtime-migration job which runs unit tests for runtime migration (more info here: #5865). The job runs on every PR and checks if the PR has the E1-runtimemigration label. If yes - the test is started.

Log of the successful job can be found here

Closes https://github.com/paritytech/ci_cd/issues/573

@alvicsam alvicsam requested a review from a team as a code owner August 16, 2022 15:57
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 16, 2022
@paritytech-ci paritytech-ci requested a review from a team August 16, 2022 15:57
@alvicsam alvicsam added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Aug 16, 2022
@alvicsam alvicsam removed the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Aug 17, 2022
@alvicsam alvicsam changed the title [WIP] Playground for check-runtime-migration [ci] Add check-runtime-migration job Aug 17, 2022
.gitlab-ci.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team August 17, 2022 09:28
@alvicsam alvicsam merged commit 520e10b into master Aug 17, 2022
@alvicsam alvicsam deleted the as-ci-test-runtime branch August 17, 2022 10:35
@kianenigma
Copy link
Contributor

THANK YOU SIR. 🎩 ❤️

@kianenigma
Copy link
Contributor

against which nodes are you running this?

@alvicsam
Copy link
Contributor Author

It runs on general ci-nodes. Should it be on bm* runners?

ordian added a commit that referenced this pull request Aug 29, 2022
* master: (23 commits)
  Bump futures-util from 0.3.21 to 0.3.23 (#5922)
  Companion for 12095 (#5924)
  use generated preimage weight (#5904)
  Update Substrate to make companion check happy (#5934)
  Fix wrong logic. (#5931)
  update weights (#5911)
  Clean up MigrateToV10 (#5921)
  Bump async-trait from 0.1.56 to 0.1.57 (#5919)
  Send back empty votes + log in approval-voting in case candidate entry is missing. (#5925)
  chore: bump zombienet version (#5914)
  Bump indexmap from 1.9.0 to 1.9.1 (#5918)
  Bump proc-macro2 from 1.0.40 to 1.0.43 (#5878)
  Bump hyper from 0.14.19 to 0.14.20 (#5901)
  Fix output file for updating weights in run_benches_for_runtime.sh (#5906)
  Companion to Substrate PR 12006 (#5913)
  pin gha versions (#5916)
  Companion for new Trie cache (#5897)
  [ci] Add check-runtime-migration job (#5891)
  Governance 2 (Part 1, Non-Controversial Changes) (#5892)
  Added Dwellir bootnodes for Kusama and Polkadot (#5772)
  ...
@kianenigma
Copy link
Contributor

Seems to be failing in #5930

@kianenigma
Copy link
Contributor

If we can create a daily job that just generates snapshots for all 3 networks for try-runtime, and then use those files in the CI (and download links so developers can use them locally) that's speed up the CI a lot.

@alvicsam
Copy link
Contributor Author

Seems to be failing in #5930

Yes, but the job itself works correctly but tests failed: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1853827

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants