Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve XCM fuzzer #6190

Merged
merged 10 commits into from
Feb 23, 2023
Merged

Improve XCM fuzzer #6190

merged 10 commits into from
Feb 23, 2023

Conversation

louismerlin
Copy link
Contributor

The XCM fuzzer was improved internally by @srlabs, here are the changes we've made over time.

Changes include:

  • one more parachain (bringing the total to 1 relay chain and 3 parachains)
  • messages now have a source and a destination chain
  • 5 messages per fuzzer input instead of 1
  • overall improvements to code readability and logs

I've also added a README for easier handling of the tool.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 30, 2022
@KiChjang @kianenigma
Add newline
5860cef 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@mrcnski
Copy link
Contributor

mrcnski commented Nov 2, 2022

I ran this and found a number of crashes. Is this expected? Should I report them and if so, how?

@louismerlin
Copy link
Contributor Author

I ran this and found a number of crashes. Is this expected? Should I report them and if so, how?

IIRC one crash is a debug_assert that we have reported as being too easily reachable in debug mode (but the Parity team decided against taking any action, as this is not a security issue), and the other one is a crash due to the fact we are running a mock XCM environment. Both should be commented out in order to find potential real bugs.

@mrcnski
Copy link
Contributor

mrcnski commented Nov 8, 2022

@louismerlin CI is failing, looks like you need to update Cargo.lock:

error: the lock file /builds/parity/mirrors/polkadot/Cargo.lock needs to be updated but --locked was passed to prevent this

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 19a33d5

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 48f41dd into paritytech:master Feb 23, 2023
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
7785be8 
* master: (98 commits)
  Ensure max_weight is assigned properly in AllowTopPaidExecutionFrom (#6787)
  Explicitly Handling ProvisionableData Cases (#6757)
  Companion for Substrate#12520 (#6730)
  Revert back to bare metal runners for weights generation (#6762)
  Improve XCM fuzzer (#6190)
  Corrected weight trader comment (#6752)
  clean up executed migrations (#6763)
  Remove state migration from westend runtime. (#6737)
  polkadot companion #12608 (Pools claim permissions) (#6753)
  Add Turboflakes bootnodes to Polkadot, Kusama and Westend (#6628)
  Companion for substrate#13284 (#6653)
  Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#6734)
  Companion PR for PR#13119 (#6683)
  Companion for Substrate#13411: frame/beefy: prune entries in set id session mapping (#6743)
  `BlockId` removal: refactor of runtime API (#6721)
  Fix auction bench (#6747)
  Use PVF code paired with executor params wherever possible (#6742)
  Retire `OldV1SessionInfo` (#6744)
  Companion for substrate #13121 - BEEFY Equivocations support (#6593)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma kianenigma approved these changes

@mrcnski mrcnski mrcnski approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@louismerlin @mrcnski @KiChjang @kianenigma @ordian