Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix spending limits comments of gov2 origins #6310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix spending limits comments of gov2 origins #6310

wants to merge 1 commit into from

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Nov 18, 2022

paradox-tt
paradox-tt reviewed Nov 21, 2022
View reviewed changes
Copy link

@paradox-tt paradox-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see someone else noticed the incorrect comments!

Just a suggestion that all units should remain the same (KSM) and there should be standard decimal places (3).

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Nov 21, 2022
@ggwpez
Copy link
Member

ggwpez commented Nov 21, 2022

image
#5205 (comment)

Maybe we rather update the constants to be on-par with the comments.

@paradox-tt
Copy link

I wouldn't be comfortable altering these limits seeing that this is now live. Any changes to such limits should be done under some governance directive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paradox-tt paradox-tt paradox-tt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong spending limit comments in Kusama governance config
4 participants
@brenzi @ggwpez @paradox-tt @bkchr