This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Reduce provisioner work #6328
Merged
Merged
Reduce provisioner work #6328
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0b8ca58
Store values needed to create inherent data when needed instead of cr…
2133341
Point deps to substrate branch
d3a7a7f
Arc the client
b57bdcc
Cargo update
c6bd3f0
Fix main cargo files
a7200dc
Undo cargo file changes
bfda13f
Add overseer dep to inherents
6715c56
Update deps
c49f64b
Simplify code
3c5675c
Merge branch 'master' into alex/reduce_provisioner_work
a1e9ddf
Update benchmark
dc9c98c
Update node/client/src/benchmarking.rs
816c92d
Update node/core/parachains-inherent/src/lib.rs
8b9555d
Update node/core/parachains-inherent/src/lib.rs
1137a65
Revert "Update node/core/parachains-inherent/src/lib.rs"
0d9b9b5
Revert "Update node/core/parachains-inherent/src/lib.rs"
d242d8b
Merge branch 'master' into alex/reduce_provisioner_work
58c1e8c
cargo update -p sp-io
a990e04
fmt
8fca5f1
cargo update -p sp-io
ggwpez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the logic in this function should be moved into the
provide_inherent_data
function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so? I like how this is actually a separate function handing all the data gathering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still put it into a separate function. I just don't like the duplication of the InherentDataProvider. This doesn't make any sense to me.