This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for: try-runtime::fast-forward
#6567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Feb 1, 2023
cli/src/command.rs
Outdated
| @@ -27,6 +27,9 @@ use sp_core::crypto::Ss58AddressFormatRegistry; | |||
| use sp_keyring::Sr25519Keyring; | |||
| use std::net::ToSocketAddrs; | |||
|
|
|||
| #[cfg(feature = "try-runtime")] | |||
| use try_runtime_cli::block_building_info::timestamp_with_babe_info; | |||
There was a problem hiding this comment.
I would move this to line 641 inside the feature-gated scope. There is already a few imports there.
kianenigma
approved these changes
Feb 1, 2023
sam0x17
approved these changes
Feb 10, 2023
Ank4n
approved these changes
Feb 11, 2023
Ank4n
reviewed
Feb 11, 2023
Ank4n
reviewed
Feb 11, 2023
kianenigma
added
A0-please_review
added 2 commits
February 17, 2023 12:22
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 0cd1aa7 |
Merged
|
bot rebase |
|
Rebased |
|
Superseeded by #6747 |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion for paritytech/substrate#12896